Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
start: Remove outdated comment about group dropping
Commit b58214a (tree-wide: improve setgroups() dropping) moved the
group dropping code to occur before lxc_switch_uid_gid. Therefore this
comment is no longer correct.

Signed-off-by: Filip Schauer <[email protected]>
  • Loading branch information
Filiprogrammer committed Dec 15, 2025
commit e6ad17a796ae056337744980fb0719607a6be985
3 changes: 0 additions & 3 deletions src/lxc/start.c
Original file line number Diff line number Diff line change
Expand Up @@ -1307,9 +1307,6 @@ static int do_start(void *data)
if (!handler->conf->root_nsgid_map)
nsgid = handler->conf->init_gid;

/* Drop groups only after we switched to a valid gid in the new
* user namespace.
*/
if (!lxc_drop_groups() &&
(handler->am_root || errno != EPERM))
goto out_warn_father;
Expand Down