Skip to content

Support for iam managed policies and goodies #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrieanKhisbe merged 10 commits into from
Jun 8, 2020
Merged

Support for iam managed policies and goodies #2

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9384306
Added supported for iamManagedPolicies at the provider and function l…
emilhdiaz Feb 21, 2019
916afd2
Slight bump of typescript to have arbitrary CFN recursive type
AdrieanKhisbe May 29, 2020
70a32e8
Dummy commit removing trailing space in tests
AdrieanKhisbe May 29, 2020
48a8ed0
Fix typo, lint and refactor tests
AdrieanKhisbe May 29, 2020
33373d4
Add tests for iamManagedPolicies support
AdrieanKhisbe May 29, 2020
f93fd65
Test on travis on locked serverless version
AdrieanKhisbe May 29, 2020
bdbf0e0
Replace prepublishOnly with prepare to enable npm git install
AdrieanKhisbe Jun 2, 2020
3d21c53
Avoid duplication of managedPolicies (and collection refactor)
AdrieanKhisbe Jun 2, 2020
efa7648
Do not add implicit VPC managed policies when explicitely set
AdrieanKhisbe Jun 2, 2020
8c97bed
Do not ensure global role is present as not inserted anymore by serve…
AdrieanKhisbe Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Do not ensure global role is present as not inserted anymore by serve… 
…rless ⚡

cf serverless/serverless#7722
  • Loading branch information
@AdrieanKhisbe
AdrieanKhisbe committed Jun 3, 2020
commit 8c97bedeb8489c1fefd7b5704bb413cee6a89a21
12 changes: 0 additions & 12 deletions src/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,6 @@ describe('plugin tests', function(this: any) {
assert.equal(sqsMapping.DependsOn, "SqsHandlerIamRoleLambdaExecution");
});

it('ensure global role is present', () => {
const helloNoPerFunctionResource = serverless.service.provider.compiledCloudFormationTemplate.Resources.HelloNoPerFunctionLambdaFunction;
assert.isTrue(helloNoPerFunctionResource.DependsOn.indexOf('IamRoleLambdaExecution') >= 0, 'function resource depends on global role');
assert.equal(helloNoPerFunctionResource.Properties.Role["Fn::GetAtt"][0], 'IamRoleLambdaExecution', "function resource role is set to global role");
});

it('ensure empty IAM statements are supported', () => {
const helloEmptyIamStatementsRole =
serverless.service.provider.compiledCloudFormationTemplate.Resources.HelloEmptyIamStatementsIamRoleLambdaExecution;
Expand Down Expand Up @@ -475,12 +469,6 @@ describe('plugin tests', function(this: any) {
assert.equal(sqsMapping.DependsOn, "SqsHandlerIamRoleLambdaExecution");
});

it('ensure global role is present', () => {
const helloNoPerFunctionResource = serverless.service.provider.compiledCloudFormationTemplate.Resources.HelloNoPerFunctionLambdaFunction;
assert.isTrue(helloNoPerFunctionResource.DependsOn.indexOf('IamRoleLambdaExecution') >= 0, 'function resource depends on global role');
assert.equal(helloNoPerFunctionResource.Properties.Role["Fn::GetAtt"][0], 'IamRoleLambdaExecution', "function resource role is set to global role");
});

it('ensure empty IAM managed are supported', () => {
const helloEmptyIamPolicyRole =
serverless.service.provider.compiledCloudFormationTemplate.Resources.HelloEmptyIamPoliciesIamRoleLambdaExecution;
Expand Down