Skip to content

implement lazy loading #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristiandnm merged 6 commits into from
Oct 3, 2025
Merged

implement lazy loading #316

cristiandnm merged 6 commits into from
Oct 3, 2025

Conversation

@seanzhangkx8
Copy link
Collaborator

@seanzhangkx8 seanzhangkx8 commented Sep 12, 2025

Description

  • Implemented lazy loading: Core modules imported immediately, others loaded on first access
  • Modules' error handling are done by modules themselves, and would only be displayed if the module is imported
  • Moved LLM dependency package handling from script files to module init.py files
  • Replaced print statements with proper ImportError raising

vianxnguyen
vianxnguyen approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@vianxnguyen vianxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@cristiandnm cristiandnm merged commit 0bda800 into CornellNLP:master Oct 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vianxnguyen vianxnguyen vianxnguyen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seanzhangkx8 @vianxnguyen @cristiandnm