Skip to content

Add newtype string support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethanfrey merged 2 commits into from
Dec 20, 2019
Merged

Add newtype string support #5

ethanfrey merged 2 commits into from
Dec 20, 2019

Conversation

@ethanfrey
Copy link

@ethanfrey ethanfrey commented Dec 20, 2019

This allows structs defining newtypes to deserialize properly. eg:

    #[derive(Deserialize, Clone, Debug, PartialEq)]
    pub struct Address(pub String);

    #[derive(Deserialize, Clone, Debug, PartialEq)]
    pub struct NewtypeDemo {
        pub address: Address,
    }

@ethanfrey ethanfrey merged commit 8a4e4a2 into master Dec 20, 2019
@ethanfrey ethanfrey deleted the add-newtype-string-support branch December 20, 2019 14:01
webmaster128
webmaster128 reviewed Dec 20, 2019
View reviewed changes
src/de/mod.rs

/// Unsupported. We can’t parse newtypes because we don’t know the underlying type.
fn deserialize_newtype_struct<V>(self, _name: &'static str, _visitor: V) -> Result<V::Value>
fn deserialize_newtype_struct<V>(self, _name: &'static str, visitor: V) -> Result<V::Value>
Copy link
Member

@webmaster128 webmaster128 Dec 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment still up-to-date?

Copy link
Author

@ethanfrey ethanfrey Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. i am bad about updating comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanfrey @webmaster128