Skip to content

Conversation

@webmaster128
Copy link
Member

@CyberHoward
Copy link

I remember adding the collect_str because the semver serialization didn't work (https://github.com/dtolnay/semver/blob/master/src/serde.rs).

Was there an update to the default implementation in that time?

@webmaster128
Copy link
Member Author

I remember adding the collect_str because the semver serialization didn't work (https://github.com/dtolnay/semver/blob/master/src/serde.rs).

In #51 you removed an unreachable and added the implementation that is the default implementation of that function. This default implementation probably existed all the time but it was overridden by the panic.

@CyberHoward
Copy link

Whoeps, sorry for that!

@webmaster128 webmaster128 merged commit 1c0fdbb into main Apr 11, 2023
@webmaster128 webmaster128 deleted the fix-collect_str branch April 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants