Add recursion limit for 0.5.2 #64
Conversation
| Deserializer { | ||
| slice, | ||
| index: 0, | ||
| remaining_depth: 128, |
There was a problem hiding this comment.
Isn't this a bit high for inside of a contract?
There was a problem hiding this comment.
Yes, but it's already nowhere near the number that could cause a stack overflow. Is there a reason to lower it further?
There was a problem hiding this comment.
Both stack overflow and OOM in Wasm can be at a very different point than the stack overflow when running natively on some modern dev machine. Also memory limit is configurable and may just be a few megabytes. Did you test this in Wasm too?
There was a problem hiding this comment.
With a test like the one in this PR, but as wasm code, it hits stack overflow somewhere between AMOUNT = 4000 and 4500. Memory didn't seem to be a problem. I tested with the make_testing_options() in cosmwasm-vm, so 16MB.
There was a problem hiding this comment.
Sounds good. Alright then, let's keep the value. Thanks for the confirmation.
I created the release/0.5 branch for this, as it didn't exist yet.
This is a simplified version of the check serde-json does