Skip to content

Fix JSONDecodeError import in functions util #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
subbu-cs wants to merge 14 commits into from
Closed

Fix JSONDecodeError import in functions util #1384

subbu-cs wants to merge 14 commits into from

Conversation

@subbu-cs
Copy link

@subbu-cs subbu-cs commented Oct 15, 2025 •
edited by jshcodes
Loading

Fix JSONDecodeError import in functions util

  • Bug fixes

Unit test coverage

TODO

COVERAGE RESULTS SHOULD BE POSTED HERE
PLEASE REVIEW CONTRIBUTING.md FOR MORE
DETAILS ON GENERATING COVERAGE RESULTS

Bandit analysis

BANDIT ANALYSIS RESULTS SHOULD BE POSTED
HERE. PLEASE REVIEW CONTRIBUTING.md FOR
MORE DETAILS ON GENERATING BANDIT RESULTS

Added features and functionality

None

Issues resolved

  • Fixes JSONDecodeError import in functions util

Other

None

@jshcodes jshcodes force-pushed the dev branch 3 times, most recently from e4436b7 to d59e4aa Compare November 8, 2025 04:31
@jshcodes jshcodes force-pushed the dev branch 9 times, most recently from 1a741d7 to 0860e4e Compare November 17, 2025 08:02
@subbu-cs subbu-cs marked this pull request as ready for review November 18, 2025 17:57
dweissbacher and others added 6 commits November 18, 2025 22:40
@dweissbacher @subbu-cs
Add WorkflowDefinitionsStatus endpoint and corresponding method in Wo…
9cd61aa 
…rkflows class
@subbu-cs
added GetSensorUsageHourly as this allows you to pull hourly for Cl…
111b534 
…oud based; added it to test sensor; tested it in production and works since the endpoint does work and provides hourly usage billing that is used for Cloud (reserved hourly) usage
@subbu-cs
Fix JSONDecodeError import in functions
3c19556
@subbu-cs
Fix lint issues
ef965ba
@subbu-cs
Fix more lint issues
11762ac
@subbu-cs
Fix merge error in _sensor_usage.py
f2ee2cc
@jshcodes jshcodes force-pushed the dev branch 2 times, most recently from 7618ced to 25ba573 Compare November 19, 2025 08:30
@jshcodes
Copy link
Member

jshcodes commented Nov 19, 2025

Merging this change into dev for local unit testing.

jshcodes
jshcodes approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@jshcodes jshcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙇

@subbu-cs
Copy link
Author

subbu-cs commented Nov 19, 2025

Created #1393 for cleaner commits.

@subbu-cs subbu-cs closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jshcodes jshcodes jshcodes approved these changes

@crowdstrikedcs crowdstrikedcs Awaiting requested review from crowdstrikedcs crowdstrikedcs is a code owner

Assignees

@subbu-cs subbu-cs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@subbu-cs @jshcodes @dweissbacher