Skip to content

Service Class fixes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jshcodes merged 20 commits into from
Dec 26, 2020
Merged

Service Class fixes #30

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2541832
Default parameter debugging. Ran the code through the DRYer.
jshcodes Dec 24, 2020
1798e4e
Param defaults, fixes to GetDeviceDetails, DRYer
jshcodes Dec 25, 2020
c0a060b
Parameter defaults, DRYer, Unit testing
jshcodes Dec 25, 2020
db407db
Parameter cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 25, 2020
c8797c2
Param, partition, content-type fixes. Unit tests.
jshcodes Dec 25, 2020
3cdc609
Parameter cleanup, DRYer
jshcodes Dec 25, 2020
8a91ae4
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
8bb115d
Param cleanup, IDs fix, DRYer, More to do here
jshcodes Dec 26, 2020
f954ffc
Param cleanup, IDs fixes, DRYer
jshcodes Dec 26, 2020
df1e1a3
Param cleanup, IDs fixes, DRYer
jshcodes Dec 26, 2020
2951989
Param cleanup, IDs fix, DRYer
jshcodes Dec 26, 2020
65c5fe8
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
5a22b44
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
1d3117a
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
57feb89
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
9f47581
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
067fbe7
Param cleanup, IDs fix, DRYer, Unit testing
jshcodes Dec 26, 2020
d4215cd
Param cleanup, IDs fix, DRYer, Unit test prep
jshcodes Dec 26, 2020
903b7d8
Param cleanup, IDs fix, DRYer, Basic unit tests
jshcodes Dec 26, 2020
11f6b81
Quick run thru the DRYer
jshcodes Dec 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Param cleanup, IDs fix, DRYer, Unit testing
  • Loading branch information
@jshcodes
jshcodes committed Dec 26, 2020
commit 8a91ae4d03e2d004ac80866bc3536bbc0eefef47
74 changes: 32 additions & 42 deletions src/falconpy/device_control_policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,37 +61,35 @@ def __call__(self, status_code, headers, body):

return self.result_obj

def queryCombinedDeviceControlPolicyMembers(self, parameters):
def queryCombinedDeviceControlPolicyMembers(self, parameters={}):
""" Search for members of a Device Control Policy in your environment by providing an FQL filter
and paging details. Returns a set of host details which match the filter criteria.
"""
# [GET] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/queryCombinedDeviceControlPolicyMembers
FULL_URL = self.base_url+'/policy/combined/device-control-members/v1'
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("GET", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

def queryCombinedDeviceControlPolicies(self, parameters):
def queryCombinedDeviceControlPolicies(self, parameters={}):
""" Search for Device Control Policies in your environment by providing an FQL filter and
paging details. Returns a set of Device Control Policies which match the filter criteria.
"""
# [GET] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/queryCombinedDeviceControlPolicies
FULL_URL = self.base_url+'/policy/combined/device-control/v1'
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("GET", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

Expand All @@ -104,12 +102,11 @@ def performDeviceControlPoliciesAction(self, parameters, body):
HEADERS = self.headers
BODY = body
PARAMS = parameters
result = self.Result()
try:
response = requests.request("POST", FULL_URL, params=PARAMS, json=BODY, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

Expand All @@ -122,27 +119,25 @@ def setDeviceControlPoliciesPrecedence(self, body):
FULL_URL = self.base_url+'/policy/entities/device-control-precedence/v1'
HEADERS = self.headers
BODY = body
result = self.Result()
try:
response = requests.request("POST", FULL_URL, json=BODY, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

def getDeviceControlPolicies(self, parameters):
def getDeviceControlPolicies(self, ids):
""" Retrieve a set of Device Control Policies by specifying their IDs. """
# [GET] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/getDeviceControlPolicies
FULL_URL = self.base_url+'/policy/entities/device-control/v1'
ID_LIST = str(ids).replace(",","&ids=")
FULL_URL = self.base_url+'/policy/entities/device-control/v1?ids={}'.format(ID_LIST)
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("GET", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
response = requests.request("GET", FULL_URL, headers=HEADERS, verify=False)
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

Expand All @@ -152,27 +147,25 @@ def createDeviceControlPolicies(self, body):
FULL_URL = self.base_url+'/policy/entities/device-control/v1'
HEADERS = self.headers
BODY = body
result = self.Result()
try:
response = requests.request("POST", FULL_URL, json=BODY, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

def deleteDeviceControlPolicies(self, parameters):
def deleteDeviceControlPolicies(self, ids):
""" Delete a set of Device Control Policies by specifying their IDs. """
# [DELETE] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/createDeviceControlPolicies
FULL_URL = self.base_url+'/policy/entities/device-control/v1'
ID_LIST = str(ids).replace(",","&ids=")
FULL_URL = self.base_url+'/policy/entities/device-control/v1?ids={}'.format(ID_LIST)
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("DELETE", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
response = requests.request("DELETE", FULL_URL, headers=HEADERS, verify=False)
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

Expand All @@ -182,45 +175,42 @@ def updateDeviceControlPolicies(self, body):
FULL_URL = self.base_url+'/policy/entities/device-control/v1'
HEADERS = self.headers
BODY = body
result = self.Result()
try:
response = requests.request("PATCH", FULL_URL, json=BODY, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

def queryDeviceControlPolicyMembers(self, parameters):
def queryDeviceControlPolicyMembers(self, parameters={}):
""" Search for members of a Device Control Policy in your environment by providing an FQL filter
and paging details. Returns a set of Agent IDs which match the filter criteria.
"""
# [GET] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/queryDeviceControlPolicyMembers
FULL_URL = self.base_url+'/policy/queries/device-control-members/v1'
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("GET", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned

def queryDeviceControlPolicies(self, parameters):
def queryDeviceControlPolicies(self, parameters={}):
""" Search for Device Control Policies in your environment by providing an FQL filter and paging details.
Returns a set of Device Control Policy IDs which match the filter criteria.
"""
# [GET] https://assets.falcon.crowdstrike.com/support/api/swagger.html#/device-control-policies/queryDeviceControlPolicyMembers
FULL_URL = self.base_url+'/policy/queries/device-control/v1'
HEADERS = self.headers
PARAMS = parameters
result = self.Result()
try:
response = requests.request("GET", FULL_URL, params=PARAMS, headers=HEADERS, verify=False)
returned = result(response.status_code, response.headers, response.json())
returned = self.Result()(response.status_code, response.headers, response.json())
except Exception as e:
returned = result(500, {}, str(e))
returned = self.Result()(500, {}, str(e))

return returned