Updated sample to use python dict get() method to avoid KeyNotFound e… #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception Is this a breaking change? - No Are all new or changed code paths covered by unit testing? - n/a A complete listing of issues addressed or closed with this change. - updated to use python dict `get()` method to return None instead of a KeyNotFound exception A complete listing of any enhancements provided by this change. - n/a Any usage details developers may need to make use of this new functionality. - no Does additional documentation need to be developed beyond what is listed in your Pull Request? - no Any other salient points of interest.
jshcodes
approved these changes
Sep 15, 2021
Member
jshcodes
left a comment
jshcodes
left a comment
There was a problem hiding this comment.
Excellent call. Thank you for submitting a fix! 😄
jshcodes
added
code samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update resolves an issue within the sensor_versions_by_hostname sample.
Issues resolved
get()method to return None instead of aKeyNotFoundexception