Skip to content

Update hyperlink styles based on style guide (No JIRA ticket)#1262

Merged
mandyshafer merged 3 commits intomasterfrom
hyperlink-styles
Feb 2, 2026
Merged

Update hyperlink styles based on style guide (No JIRA ticket)#1262
mandyshafer merged 3 commits intomasterfrom
hyperlink-styles

Conversation

@mandyshafer
Copy link
Contributor

@mandyshafer mandyshafer commented Jan 29, 2026

Description

  • We have an updated style guide for hyperlinks
  • Hyperlinks should have the arrow icon next to them, and get the lighter blue color on hover. Hyperlinks are still underlined.
  • This should not affect any buttons.

Testing

  • Go to various pages with hyperlinks (thank you page, more ways to give, search)
  • Verify the updated hover state color and new icon

Checklist:

  • I have given my PR a title with the format "EP-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "On Staging" to get the branch automatically merged into staging)
  • I have requested a review from another person on the project
  • I have checked that stage-branch-merger successfully merged my branch to staging or manually merged it myself
  • I have tested my changes in staging for regular checkout
  • I have tested my changes in staging for branded checkout

@mandyshafer mandyshafer added the On Staging Will be merged into the staging branch by GitHub Actions label Jan 29, 2026
@stage-branch-merger
Copy link

I see you added the "On Staging" label, I'll get this merged to the staging branch!

@mandyshafer mandyshafer changed the title Update hyperlink styles based on style guide (No JIRA ticket) WIP: Update hyperlink styles based on style guide (No JIRA ticket) Jan 29, 2026
@wrandall22 wrandall22 requested a review from rguinee January 29, 2026 19:57
Copy link
Contributor

@rguinee rguinee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @mandyshafer. I tested it on Chrome desktop and mobile on a Mac and the hyperlink style changes look good. On Windows Chrome there was an odd font rendering situation that made the top part of the arrow-outward icon seem thinner than the spine of the arrow. It's negligible though and looks correct when the browser zoom increases. Just an oddity with font renderings.

@mandyshafer
Copy link
Contributor Author

@rguinee I had noticed that font rendering issue too.

Do you think we need to update the hyperlink styles for pages like https://give.cru.org/more-ways-to-give/stock-and-non-cash-gifts.html ? It looks like it uses an old template and shows styles from ui.apps/src/main/content/jcr_root/apps/CruOrgApp/components/page/htmlbase/clientlibs/css/common.css in the cruorgaem6 codebase.

@wrandall22
Copy link
Contributor

Those pages are slated for a redesign and reimplementation in this next cycle of work for our team, so it may not be worth the effort updating them now.

@mandyshafer mandyshafer changed the title WIP: Update hyperlink styles based on style guide (No JIRA ticket) Update hyperlink styles based on style guide (No JIRA ticket) Jan 29, 2026
@mandyshafer mandyshafer merged commit 8f23701 into master Feb 2, 2026
5 checks passed
@mandyshafer mandyshafer deleted the hyperlink-styles branch February 2, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Staging Will be merged into the staging branch by GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants