Update hyperlink styles based on style guide (No JIRA ticket)#1262
Update hyperlink styles based on style guide (No JIRA ticket)#1262mandyshafer merged 3 commits intomasterfrom
Conversation
|
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
rguinee
left a comment
There was a problem hiding this comment.
Thanks for this PR, @mandyshafer. I tested it on Chrome desktop and mobile on a Mac and the hyperlink style changes look good. On Windows Chrome there was an odd font rendering situation that made the top part of the arrow-outward icon seem thinner than the spine of the arrow. It's negligible though and looks correct when the browser zoom increases. Just an oddity with font renderings.
|
@rguinee I had noticed that font rendering issue too. Do you think we need to update the hyperlink styles for pages like https://give.cru.org/more-ways-to-give/stock-and-non-cash-gifts.html ? It looks like it uses an old template and shows styles from ui.apps/src/main/content/jcr_root/apps/CruOrgApp/components/page/htmlbase/clientlibs/css/common.css in the cruorgaem6 codebase. |
|
Those pages are slated for a redesign and reimplementation in this next cycle of work for our team, so it may not be worth the effort updating them now. |
Description
Testing
Checklist:
stage-branch-mergersuccessfully merged my branch to staging or manually merged it myself