Skip to content

[no-Jira] Add closing tag to sign-in-modal#1263

Merged
canac merged 1 commit intomasterfrom
closing-tag
Mar 5, 2026
Merged

[no-Jira] Add closing tag to sign-in-modal#1263
canac merged 1 commit intomasterfrom
closing-tag

Conversation

@canac
Copy link
Contributor

@canac canac commented Mar 4, 2026

Description

Fixes DataDog errors like this one:

HTML tags must be properly nested and closed: <div class=modal-body> <div class=content> <sign-in-form on-success=$ctrl.onSuccess() on-failure=$ctrl.onFailure() last-purchase-id=$ctrl.lastPurchaseId on-sign-up-with-okta=$ctrl.onSignUp() on-reset-password=$ctrl.onResetPassword() /> </div> </div> 

Testing

No user-facing changes

Checklist:

  • I have given my PR a title with the format "EP-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "On Staging" to get the branch automatically merged into staging)
  • I have requested a review from another person on the project
  • I have checked that stage-branch-merger successfully merged my branch to staging or manually merged it myself
  • I have tested my changes in staging for regular checkout
  • I have tested my changes in staging for branded checkout

@canac canac requested a review from wjames111 March 4, 2026 17:51
@canac canac self-assigned this Mar 4, 2026
@canac canac added the On Staging Will be merged into the staging branch by GitHub Actions label Mar 4, 2026
@stage-branch-merger
Copy link

I see you added the "On Staging" label, I'll get this merged to the staging branch!

Copy link
Contributor

@wjames111 wjames111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review on such a simple change!

@canac canac merged commit 3b44466 into master Mar 5, 2026
5 checks passed
@canac canac deleted the closing-tag branch March 5, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Staging Will be merged into the staging branch by GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants