Skip to content

Conversation

@leonsteinhaeuser
Copy link
Contributor

As part of our customization's to the PostgreSQL cluster, we discovered that it is currently not possible to change the storage class for predefined instances. Since our cluster infrastructure contains more than one storage class with different underlying storage technologies, it is necessary for us to select a specific storage class. We found that this is already possible when we define our own instance, but we thought it would be more useful to simply add this functionality to the chart.

@benjaminjb
Copy link
Contributor

Hello, thanks for the PR, I've made a few comments on it to (a) correct a slight mistake and (b) bring it in line with the multiline if...end format we've established.

Also, at least for the backup repo section, have you ever tried to put all the necessary info into the pgBackRestConfig field in the values.yaml? I wonder how that would work for that specific part of the template.

@leonsteinhaeuser
Copy link
Contributor Author

@benjaminjb thank you very much for your reply and review. I will look at it asap and update the PR.

leonsteinhaeuser and others added 3 commits November 15, 2022 14:31
Co-authored-by: Benjamin Blattberg <[email protected]>
Co-authored-by: Benjamin Blattberg <[email protected]>
Co-authored-by: Benjamin Blattberg <[email protected]>
@leonsteinhaeuser
Copy link
Contributor Author

@benjaminjb I have accepted your changes.

Also, at least for the backup repo section, have you ever tried to put all the necessary info into the pgBackRestConfig field in the values.yaml?

I did that and it worked quite well. Since we already supported custom volume sizes at the top level, I thought it would be useful to support customization for storage classes as well.

@ValClarkson ValClarkson merged commit efdadb3 into CrunchyData:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants