Improve fix/stuck-squad
#1453
Draft
Improve fix/stuck-squad
#1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update stuck-squad.lua * Update notifications.lua * Update registry.lua * Update stuck-squad.rst
Bumber64
commented
May 6, 2025
| --From observing bugged saves, this condition appears to be unique to stuck armies | ||
| local function is_army_stuck(army) | ||
| return army and not army.flags.dwarf_mode_preparing and --Let DF handle cancelled missions | ||
| army.controller_id ~= 0 and not army.controller |
There was a problem hiding this comment.
Why is a controller_id of 0 excluded, specifically?
|
May need changes due to v52.03-04 army handling. Tool may be obsolete due to remaining army issues having a different cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach new controller based on how DF handles cancelled missions, rather than requiring a returning squad.
Fix assumptions about one squad per army. Let DF handle squads that haven't fully left the map.
Some functions that might be useful to manipulate armies in general. (E.g., force any army to join a site.)
verboseandquietoptions.