Skip to content

NUL terminate "msg" in lessons 3 & 4 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

NUL terminate "msg" in lessons 3 & 4 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/lesson3/helloworld-len.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; Run with: ./helloworld-len

SECTION .data
msg db 'Hello, brave new world!', 0Ah ; we can modify this now without having to update anywhere else in the program
msg db 'Hello, brave new world!', 0Ah, 0h ; we can modify this now without having to update anywhere else in the program

SECTION .text
global _start
Expand Down Expand Up @@ -35,4 +35,4 @@ finished:

mov ebx, 0
mov eax, 1
int 80h
int 80h
4 changes: 2 additions & 2 deletions code/lesson4/helloworld-len.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; Run with: ./helloworld-len

SECTION .data
msg db 'Hello, brave new world!', 0AH
msg db 'Hello, brave new world!', 0AH, 0h

SECTION .text
global _start
Expand Down Expand Up @@ -37,4 +37,4 @@ nextchar: ; this is the same as lesson3
finished:
sub eax, ebx
pop ebx ; pop the value on the stack back into EBX
ret ; return to where the function was called
ret ; return to where the function was called
4 changes: 2 additions & 2 deletions docs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ <h5>Writing our program</h5>
; Run with: ./helloworld-len

SECTION .data
msg db 'Hello, brave new world!', 0Ah ; we can modify this now without having to update anywhere else in the program
msg db 'Hello, brave new world!', 0Ah, 0h ; we can modify this now without having to update anywhere else in the program

SECTION .text
global _start
Expand Down Expand Up @@ -619,7 +619,7 @@ <h5>Introduction to the stack</h5>
; Run with: ./helloworld-len

SECTION .data
msg db 'Hello, brave new world!', 0Ah
msg db 'Hello, brave new world!', 0Ah, 0h

SECTION .text
global _start
Expand Down