fix(.envrc): add --no-pure-eval for devenv flake compatibility #20692
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update devenv.nix to match project dependencies: - Upgrade Node.js from 22 to 24 (aligns with Dockerfile node:24-bookworm) - Upgrade pnpm from 9 to 10 (aligns with package.json [email protected])
Replace external URL with mock server endpoint to prevent test timeout. The test was trying to fetch from http://example.com which is not mocked, causing it to timeout. Now uses http://rsshub.test/headers which is properly mocked in the test setup.
This fixes an issue where devenv fails when entering the directory with direnv, reporting: "devenv was not able to determine the current directory." The --no-pure-eval flag allows devenv to determine the project root via builtins.getEnv "PWD" in flake mode. Also adds .direnv, .devenv, and .pre-commit-config.yaml to .gitignore following alphabetical order as per project conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes direnv/devenv compatibility issue by adding
--no-pure-evalflag to.envrcand updates.gitignoreto exclude devenv-generated files in alphabetical order.This PR addresses the issue originally reported in #20681. I apologize for the broken direnv setup that was merged in #20597.
Related: #20681
Fixes: #20597