Skip to content

Conversation

@krischarbonneau
Copy link
Contributor

@krischarbonneau krischarbonneau commented Aug 8, 2024

ADO-266898

Fixed AB#266898

Changelog

feat:add logging for SIN and UID validation

Description of proposed changes:

This PR adds validation that checks the SIN and UID returned from the userinfo endpoint to see if they are null or not alphanumeric and logs an error if either condition isn't met.

What to test for/How to test

  1. Pull in branch
  2. Ensure cert path in Next-Auth config is changed to your local cert path (if you aren't running in Docker)
  3. Type npm run dev
  4. Login and navigate back to MSCA-D
  5. Confirm there aren't any error logs saying the values aren't valid (you can also change the condition to look for true to force the error)

@krischarbonneau krischarbonneau requested a review from a team as a code owner August 8, 2024 14:22
@github-actions
Copy link

github-actions bot commented Aug 8, 2024

@krischarbonneau krischarbonneau merged commit 34d5d44 into dev Aug 8, 2024
@krischarbonneau krischarbonneau deleted the sin-uid-logging branch August 8, 2024 14:53
lhr-git added a commit that referenced this pull request Aug 21, 2024
* Update footer ternary to use publicRuntimeConfig value (#705)

* Update contact us page to display SIN link (#706)

* Add Root Cert Structure to Dockerfile (#707)

* Pin base image version in Dockerfile (#709)

* Update next-auth config to validate  SIN and UID (#710)

* Swapping from null to a catchall for falsy values (#711)

* Swapping from null to a catchall for falsy values (#711) (#712)

* Snyk updates bundled together (#714)

* Merging dev into staging August 19, 2024 (#715)

* Swapping from null to a catchall for falsy values (#711)

* Snyk updates bundled together (#714)

---------

Co-authored-by: Kris Charbonneau <[email protected]>
Co-authored-by: Kris Charbonneau <[email protected]>
Charles-Pham pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants