Skip to content

Run arm64 and Lambda integration tests on .NET 7 #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewlock merged 2 commits into from
Dec 5, 2022
Merged

Run arm64 and Lambda integration tests on .NET 7 #3530

andrewlock merged 2 commits into from
Dec 5, 2022

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Dec 1, 2022

Summary of changes

  • Run AWS Lambda integration tests on .NET 7
  • Run ARM64 integration tests on .NET 7

Reason for change

These were missed in the .NET 7 upgrade in #3482

Implementation details

Added net7.0 to the matrix as appropriate

Test coverage

✅ They work

Other details

Thanks @shurivich for flagging 🙏

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Dec 1, 2022
@andrewlock andrewlock requested review from a team as code owners December 1, 2022 14:31
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 1, 2022 •
edited
Loading

Datadog Report

Branch report: andrew/arm64-dotnet7
Commit report: 75b3210

✅ dd-trace-dotnet 0 Failed, 0 New Flaky, 224688 Passed, 816 Skipped, 19m 44.45s Wall Time

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock force-pushed the andrew/arm64-dotnet7 branch from d29f94a to 75b3210 Compare December 2, 2022 16:45
@andrewlock
Copy link
Member Author

andrewlock commented Dec 2, 2022

Benchmarks Report 🐌

Benchmarks for #3530 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 768μs 634ns 2.37μs 0.381 0 0 3.22 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 553μs 197ns 762ns 0 0 0 2.62 KB
#3530 WriteAndFlushEnrichedTraces net472 758μs 463ns 1.67μs 0.374 0 0 3.22 KB
#3530 WriteAndFlushEnrichedTraces netcoreapp3.1 551μs 160ns 599ns 0 0 0 2.62 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 181ns 0.0585ns 0.219ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 238ns 0.0502ns 0.181ns 0.00589 0 0 424 B
master AllCycleMoreComplexBody net472 182ns 0.0831ns 0.322ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 238ns 0.0543ns 0.203ns 0.00552 0 0 400 B
master BodyExtractorSimpleBody net472 297ns 0.43ns 1.67ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 237ns 0.0854ns 0.296ns 0.0037 0 0 272 B
master BodyExtractorMoreComplexBody net472 16.2μs 6.87ns 25.7ns 1.2 0.0161 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.6μs 3.94ns 14.7ns 0.0888 0 0 6.75 KB
#3530 AllCycleSimpleBody net472 181ns 0.0295ns 0.106ns 0.0675 0 0 425 B
#3530 AllCycleSimpleBody netcoreapp3.1 240ns 0.273ns 1.06ns 0.00587 0 0 424 B
#3530 AllCycleMoreComplexBody net472 182ns 0.1ns 0.389ns 0.0638 0 0 401 B
#3530 AllCycleMoreComplexBody netcoreapp3.1 243ns 0.378ns 1.42ns 0.00551 0 0 400 B
#3530 BodyExtractorSimpleBody net472 307ns 0.181ns 0.678ns 0.0573 0 0 361 B
#3530 BodyExtractorSimpleBody netcoreapp3.1 236ns 0.088ns 0.329ns 0.00369 0 0 272 B
#3530 BodyExtractorMoreComplexBody net472 15.7μs 12ns 46.5ns 1.21 0.0157 0 7.62 KB
#3530 BodyExtractorMoreComplexBody netcoreapp3.1 12.7μs 5.43ns 19.6ns 0.0892 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 174μs 97.1ns 376ns 0.261 0 0 20.44 KB
#3530 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3530 SendRequest netcoreapp3.1 177μs 145ns 561ns 0.264 0 0 20.44 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.82μs 1.5ns 5.82ns 0.16 0.000909 0 1.01 KB
master ExecuteNonQuery netcoreapp3.1 1.36μs 0.511ns 1.98ns 0.0135 0 0 1 KB
#3530 ExecuteNonQuery net472 1.88μs 0.9ns 3.37ns 0.16 0.000942 0 1.01 KB
#3530 ExecuteNonQuery netcoreapp3.1 1.41μs 0.487ns 1.89ns 0.0134 0 0 1 KB
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.48μs 0.816ns 2.94ns 0.193 0 0 1.22 KB
master CallElasticsearch netcoreapp3.1 1.54μs 0.808ns 3.03ns 0.0155 0 0 1.16 KB
master CallElasticsearchAsync net472 2.61μs 1.07ns 4.16ns 0.215 0 0 1.36 KB
master CallElasticsearchAsync netcoreapp3.1 1.63μs 3.3ns 12.8ns 0.0174 0 0 1.28 KB
#3530 CallElasticsearch net472 2.51μs 1.08ns 4.04ns 0.194 0 0 1.22 KB
#3530 CallElasticsearch netcoreapp3.1 1.44μs 0.697ns 2.7ns 0.0158 0 0 1.16 KB
#3530 CallElasticsearchAsync net472 2.66μs 1.1ns 4.28ns 0.215 0 0 1.36 KB
#3530 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.457ns 1.77ns 0.0177 0 0 1.28 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.76μs 1.98ns 7.68ns 0.235 0 0 1.49 KB
master ExecuteAsync netcoreapp3.1 1.8μs 0.627ns 2.26ns 0.0189 0 0 1.41 KB
#3530 ExecuteAsync net472 2.58μs 1.06ns 3.95ns 0.235 0 0 1.49 KB
#3530 ExecuteAsync netcoreapp3.1 1.74μs 0.816ns 3.16ns 0.019 0 0 1.41 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.94μs 1.48ns 5.71ns 0.448 0 0 2.83 KB
master SendAsync netcoreapp3.1 3.58μs 1.53ns 5.71ns 0.036 0 0 2.66 KB
#3530 SendAsync net472 5.82μs 1.32ns 5.11ns 0.448 0 0 2.83 KB
#3530 SendAsync netcoreapp3.1 3.64μs 1.3ns 4.88ns 0.0363 0 0 2.66 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 2.99μs 3.39ns 12.7ns 0.298 0 0 1.88 KB
master EnrichedLog netcoreapp3.1 2.27μs 1.54ns 5.78ns 0.0263 0 0 1.91 KB
#3530 EnrichedLog net472 2.84μs 1.83ns 7.1ns 0.297 0 0 1.88 KB
#3530 EnrichedLog netcoreapp3.1 2.23μs 1.76ns 6.59ns 0.0255 0 0 1.91 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 152μs 175ns 678ns 0.681 0.227 0 4.72 KB
master EnrichedLog netcoreapp3.1 121μs 197ns 762ns 0.0607 0 0 4.55 KB
#3530 EnrichedLog net472 154μs 122ns 455ns 0.69 0.23 0 4.72 KB
#3530 EnrichedLog netcoreapp3.1 122μs 182ns 680ns 0.0616 0 0 4.55 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.48μs 1.42ns 5.32ns 0.578 0.00274 0 3.65 KB
master EnrichedLog netcoreapp3.1 4.19μs 1.86ns 6.71ns 0.0544 0 0 3.98 KB
#3530 EnrichedLog net472 5.58μs 1.69ns 6.54ns 0.58 0.0028 0 3.65 KB
#3530 EnrichedLog netcoreapp3.1 4.14μs 1.95ns 7.55ns 0.0536 0 0 3.98 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.2μs 1.53ns 5.72ns 0.228 0 0 1.44 KB
master SendReceive netcoreapp3.1 1.75μs 0.924ns 3.46ns 0.0185 0 0 1.38 KB
#3530 SendReceive net472 2.3μs 2.06ns 7.98ns 0.227 0 0 1.44 KB
#3530 SendReceive netcoreapp3.1 1.8μs 1.66ns 6.42ns 0.0189 0 0 1.38 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 4.67μs 1.33ns 5.14ns 0.364 0 0 2.3 KB
master EnrichedLog netcoreapp3.1 3.98μs 2.28ns 8.22ns 0.0239 0 0 1.86 KB
#3530 EnrichedLog net472 4.82μs 1.44ns 5.39ns 0.363 0 0 2.3 KB
#3530 EnrichedLog netcoreapp3.1 3.98μs 1.38ns 4.98ns 0.0238 0 0 1.86 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.16μs 0.857ns 3.09ns 0.139 0 0 875 B
master StartFinishSpan netcoreapp3.1 946ns 0.243ns 0.875ns 0.0109 0 0 824 B
master StartFinishScope net472 1.32μs 0.395ns 1.53ns 0.151 0 0 955 B
master StartFinishScope netcoreapp3.1 1.12μs 0.392ns 1.52ns 0.0129 0 0 944 B
#3530 StartFinishSpan net472 1.12μs 0.7ns 2.62ns 0.139 0 0 875 B
#3530 StartFinishSpan netcoreapp3.1 918ns 0.406ns 1.52ns 0.0111 0 0 824 B
#3530 StartFinishScope net472 1.33μs 1.2ns 4.63ns 0.151 0 0 955 B
#3530 StartFinishScope netcoreapp3.1 1.01μs 0.317ns 1.18ns 0.0131 0 0 944 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.49μs 0.626ns 2.42ns 0.151 0 0 955 B
master RunOnMethodBegin netcoreapp3.1 1.12μs 0.638ns 2.47ns 0.0128 0 0 944 B
#3530 RunOnMethodBegin net472 1.47μs 1.09ns 4.09ns 0.151 0 0 955 B
#3530 RunOnMethodBegin netcoreapp3.1 1.16μs 0.484ns 1.81ns 0.0128 0 0 944 B

@andrewlock
Copy link
Member Author

andrewlock commented Dec 2, 2022

Code Coverage Report 📊

✔️ Merging #3530 into master will not change line coverage
✔️ Merging #3530 into master will not change branch coverage
✔️ Merging #3530 into master will not change complexity

master #3530 Change
Lines 19968 / 27203 19937 / 27203
Lines % 73% 73% 0% ✔️
Branches 11494 / 16607 11486 / 16607
Branches % 69% 69% 0% ✔️
Complexity 18026 18026 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3530 Change
Lines % 73% 73% 0% ✔️
Branches % 69% 69% 0% ✔️
Complexity 18026 18026 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Ci.GitInfo -10% ⛔ -4% ⚠️ 0 ✔️

View the full reports for further details:

@andrewlock andrewlock merged commit d2a84bc into master Dec 5, 2022
@andrewlock andrewlock deleted the andrew/arm64-dotnet7 branch December 5, 2022 10:57
@github-actions github-actions bot added this to the vNext milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests

Projects

None yet

Milestone

2.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @bouwkast