TLS Integration SMTP support #22007
Open
TLS Integration SMTP support #22007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-walker
force-pushed
the
jakew/start-tls-smtp
branch
from
70299db to
73c6d9f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
janine-c
previously approved these changes
Nov 28, 2025
temporal-github-worker-1
bot
dismissed
janine-c’s stale review
Review from janine-c is dismissed. Related teams and files:
- documentation
- tls/datadog_checks/tls/data/conf.yaml.example
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
jake-walker
force-pushed
the
jakew/start-tls-smtp
branch
from
2f55c73 to
d3e902b
Compare
jake-walker
force-pushed
the
jakew/start-tls-smtp
branch
from
d3e902b to
8246a0b
Compare
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for SMTP to the TLS integration. It adds functionality for a plain-text SMTP connection to be upgraded to TLS for the TLS integration to be able to check the certificate of the server.
I have added new code for upgrading the connection in a similar fashion to the existing MySQL and Postgres implementations. In addition, I have added a new test and container to match the existing implementations.
Motivation
This was needed at my workplace for monitoring SMTP TLS certificates.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged