Fix: Prevent mobile focus loop #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the same issue as #104 but with a different approach.
On mobile, if the header or footer contains an input field, we have an issue where the mobile phone open and close the keyboard continuously on the input field focus.
This happens because when the keyboard opens, the
resizeevent is triggered which is the event triggering the fixer header "redraw". The focus is lost during the redraw because the dom element is moved, and then, focus is reapplied to the previous active element. Which result in an infinite loop (re focusing the input will reopen the keyboard triggeringresizeevent...).With my fix, we skip the redraw if the fixed header is already properly positioned.