Skip to content

Move ctmod message dialogs to main thread to prevent segfault #124

@harpaj

Description

@harpaj

Describe the bug
Trying to install SteamTinkerLaunch (I tried version 11.11 and 11.0) crashes ProtonUp, without installing SteamTinkerLaunch.
For a split-second an error message is displayed, it took me several attempts to get a screenshot of it. Then ProtonUp crashes (SegFault in terminal).

To Reproduce
Steps to reproduce the behavior:

  1. Install for Steam
  2. Add version -> SteamTinkerLaunch -> Install
  3. Error message is displayed extremely shortly (<1s)
  4. Program crashes

Expected behavior
Program doesn't crash, SteamTinkerLaunch is installed
OR: The error message is displayed in a way I can act on it. In any case, ProtonUp shouldn't crash.

Screenshot
Screenshot from 2022-09-24 17-25-18

Desktop (please complete the following information):

  • OS: Ubuntu 20.04 without any version of yad installed
  • Version ProtonUp-Qt-2.7.4-x86_64.AppImage

Terminal output

./ProtonUp-Qt-2.7.4-x86_64.AppImage 
ProtonUp-Qt 2.7.4 by DavidoTek. Build Info: Official AppImage by DavidoTek.
Python 3.8.2 (default, Mar 13 2020, 10:14:16) [GCC 9.3.0], PySide 6.2.4
Platform: Ubuntu 20.04 Linux-5.15.0-46-generic-x86_64-with-glibc2.29
Gtk-Message: 17:18:51.364: Failed to load module "canberra-gtk-module"
Gtk-Message: 17:18:51.369: Failed to load module "canberra-gtk-module"
Loaded ctmod GE-Proton
Loaded ctmod Wine-GE
Loaded ctmod Boxtron
Loaded ctmod Kron4ek Wine-Builds Vanilla
Loaded ctmod Lutris-Wine
Loaded ctmod Luxtorpeda
Loaded ctmod Proton Tkg
Loaded ctmod Roberta
Loaded ctmod SteamTinkerLaunch
Loaded ctmod SteamTinkerLaunch-git
Loaded ctmod DXVK
Loaded ctmod DXVK Async
Loaded ctmod DXVK (nightly)
qt.pysideplugin: Environment variable PYSIDE_DESIGNER_PLUGINS is not set, bailing out.
qt.pysideplugin: No instance of QPyDesignerCustomWidgetCollection was found.
Gamepad error: No gamepad found.
QBackingStore::endPaint() called with active painter; did you forget to destroy it or call QPainter::end() on it?
Segmentation fault (core dumped)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions