Fix 32bit compatibility #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class Count64_32 is now in a namespace so the comparison was not correct anymore
Contributor
Author
|
@DeepDiver1975 Is there any chance to get this merged and released? |
Contributor
Author
|
Thanks a lot! |
Owner
|
2.0.1 is on packagist |
|
Hey @come-nc any possibility to bump https://github.com/nextcloud/3rdparty/tree/master/deepdiver/zipstreamer ? |
Contributor
Author
I only see 2.0.0: https://packagist.org/packages/deepdiver/zipstreamer |
9 tasks
joshtrichards
added a commit
to nextcloud/server
that referenced
this pull request
Oct 31, 2024
Since DeepDiver1975/PHPZipStreamer#11 was merged Signed-off-by: Josh <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4 the class Count64_32 is in a namespace.
Because of that, the comparison was not correct anymore.