Fixed make deploy* targets & added key param for securing user cookies#100
Fixed make deploy* targets & added key param for securing user cookies#100mruac wants to merge 6 commits intoDeer-Spangle:masterfrom
Conversation
The `ensure_login!` method was always returning the `FALoginCookieError` due to the `@user_cookie` returning true, so I just made it false so it won't return the error.
Fix false FALoginCookieError
fixed how vars were being passed to make deploy* commands added key query param for when accessing pages that require login cookie
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Turns out I had messed up my docker build. The code was working in the first place. Reopening this PR! |
|
Sorry for taking so long to get to these, I had a very busy end of year, just starting to get back into the swing of things with my coding projects. I'm not sure the Double quoting the variables there though is quite wise! That should definitely be done. I'm not sure whether I can merge just that bit, or whether I should just replicate it myself |
…not to your forked repo)
|
Oh darnit, I was trying out the github.dev editor, hoping I could add a commit to this PR and then land the Makefile stuff, and it pushed to your fork's master branch, sorry! |
…PR, and not to your forked repo)" This reverts commit abaa8ca.
|
Okay, cherrypicked your Makefile change in here a34d249 Thank you! |
2 participants
Added double quotes around env vars in Makefile so that passed vars are included properly.
Added
keysupport in URL query parameter orsettings.ymlfor securing endpoints where login cookie is required.