Skip to content

Allow flexibility in number of results in browse pages #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deer-Spangle merged 2 commits into from
Feb 28, 2023
Merged

Allow flexibility in number of results in browse pages #105

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
735eebb
Adding more leeway into tests about how many submissions are on a pag…
Deer-Spangle Feb 28, 2023
102682e
Adding a comment to docs about this behaviour of giving fewer than th…
Deer-Spangle Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding more leeway into tests about how many submissions are on a pag… 
…e, as often a few are missing
  • Loading branch information
@Deer-Spangle
Deer-Spangle committed Feb 28, 2023
commit 735eebb9f71cb44b44486e32e9ca88fab83c9d9a
8 changes: 4 additions & 4 deletions tests/integration/browse_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def browse_with_retry(args)
submissions.each do |submission|
expect(submission).to be_valid_submission
end
expect(submissions.length).to eql(72)
expect(submissions.length).to be_between(68, 72)
end
end

Expand All @@ -74,9 +74,9 @@ def browse_with_retry(args)
submissions48 = browse_with_retry({ "perpage" => "48" })
submissions72 = browse_with_retry({ "perpage" => "72" })

expect(submissions24.length).to eql(24)
expect(submissions48.length).to eql(48)
expect(submissions72.length).to eql(72)
expect(submissions24.length).to be_between(20, 24)
expect(submissions48.length).to be_between(44, 48)
expect(submissions72.length).to be_between(68, 72)
end

it "can specify ratings to display, and honours that selection" do
Expand Down