Skip to content

Fix favourites tests #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deer-Spangle merged 2 commits into from
Aug 21, 2023
Merged

Fix favourites tests #117

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42eb93
Cast fav ID to int before doing inequality comparison
Deer-Spangle Aug 18, 2023
91e3805
Add another to_i conversion before doing inequality check
Deer-Spangle Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add another to_i conversion before doing inequality check
  • Loading branch information
@Deer-Spangle
Deer-Spangle committed Aug 18, 2023
commit 91e3805c8f407403a211d4bf66e0bbb571d1df6f
2 changes: 1 addition & 1 deletion tests/integration/fa_parsing_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@
expect(favs_next.length).to be > (72 - 58)
expect(favs_next[0][:fav_id]).to eql(fav_id_next)
favs_next.each do |fav|
expect(fav[:fav_id]).to be < fav_id
expect(fav[:fav_id].to_i).to be < fav_id.to_i
end
end

Expand Down