Retry network failures when fetching data from FA#122
Merged
Deer-Spangle merged 1 commit intomasterfrom Mar 15, 2024
Merged
Conversation
| # Retry some types of error | ||
| if e.io.status[0] == "502" || e.io.status[0] == "520" | ||
| retry_attempts += 1 | ||
| if retry_attempts < 5 |
Check notice
Code scanning / Rubocop
Check for conditionals that can be replaced with guard clauses.
| rescue Errno::ECONNRESET => e | ||
| # Retry connection reset errors | ||
| retry_attempts += 1 | ||
| if retry_attempts < 5 |
Check notice
Code scanning / Rubocop
Check for conditionals that can be replaced with guard clauses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry up to 5 times over up to 3 seconds when trying to fetch a page, if receiving a 502 or 520 error, or a connection reset.
Send the second request right away, but then wait half a second more for each additional request.
Worst case, this will be a total of 3 seconds of sleep. Pseudo timeline:
So that should be fine in case FA is actually down or unavailable.
In testing for other projects, I've been getting 2-4 of these kind of errors a day, which are simply exposed to users as
fa_unknown, not very helpful.Hopefully this will improve that a bit!