Skip to content

2024 08 26 update and fix#124

Merged
Deer-Spangle merged 4 commits intomasterfrom
2024-08-26-update-and-fix
Aug 30, 2024
Merged

2024 08 26 update and fix#124
Deer-Spangle merged 4 commits intomasterfrom
2024-08-26-update-and-fix

Conversation

@Deer-Spangle
Copy link
Copy Markdown
Owner

This PR ends up doing a couple things.

  1. Parsing of submission author, and UserNotFound error pages were both broken by the gofundme panel. Fixed that, and hopefully made it more sturdy
  2. Note parsing was broken by the addition of a warning message to all notes
  3. The Makefile was out of date, since docker-compose became docker compose

download_url = "https:#{actions_bar.select { |a| a.content == "Download" }.first["href"]}"
profile_url = html.at_css("td.cat a")["href"][1..-1]
profile_link = html.at_css(".classic-submission-title.information a")
profile_url = profile_link["href"][1..-1]

Check notice

Code scanning / Rubocop

Checks array slicing is done with redundant, endless, and beginless ranges when suitable.

Style/SlicingWithRange: Prefer `[1..]` over `[1..-1]`.
@Deer-Spangle Deer-Spangle merged commit b5b89be into master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant