Skip to content

Fix false FALoginCookieError #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mruac wants to merge 1 commit into from
Closed

Fix false FALoginCookieError #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix false FALoginCookieError 
The `ensure_login!` method was always returning the `FALoginCookieError` due to the `@user_cookie` returning true, so I just made it false so it won't return the error.
  • Loading branch information
@mruac
mruac authored Nov 5, 2022
commit e03b89e5dbfc47574ec790da3d98d42395099041
2 changes: 1 addition & 1 deletion lib/faexport.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def set_content_type(type)
end

def ensure_login!
return if @user_cookie
return if !@user_cookie

Check notice

Code scanning / Rubocop

Favor unless over if for negative conditions (or control flow or).

Style/NegatedIf: Favor `unless` over `if` for negative conditions.
Copy link
Copy Markdown
Owner

@Deer-Spangle Deer-Spangle Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, these rubocop warnings are way noisier than I would like


raise FALoginCookieError.new(
'You must provide a valid login cookie in the header "FA_COOKIE".'\
Expand Down