Signing in with password now requires clicking Sign In button twice (or pressing Enter key twice)

[dkoo761]

I only noticed this after upgrading to Meteor 0.9.0 yesterday.

The first click on the "Sign In" button doesn't do anything. The second click signs me in.

Noticed that too. When going to the "/sign-in" page, it sets the 'fromWhere' session variable to "/sign-in" and then of course redirects to that same page.

[nunohvidal]

In accounts-entry/shared/router.coffee is setting the fromWhere session variable with the current router path

@route "entrySignIn",
    path: "/sign-in"
    onBeforeAction: ->
      Session.set('entryError', undefined)
      Session.set('buttonText', 'in')
      Session.set('fromWhere', Router.current().path)

The thing is, apparently executing Router.current().path at onBeforeAction already returns the current executing route path (future sign-in) , when we need the current (prior to click on sign-in link) route

Does anyone have a suggestion on how to fix this, while keeping the fromWhere functionality working?

[nunohvidal]

Well... this actually is the same as #218 and #239

The fix works, but here is a little issue I ran into: when coming from any route other than the ones defined in the AccountsEntry package, the dashboardRoute option is bypassed, which is strange when coming from / and you expect to get redirected to dashboard after login

[olizilla]

I ran into this too. If you'd rather not edit the accounts-entry code and are stuck on an older version, a quick workaround is to manually flip the fromWhere value in your onBeforeAction:

DashboardController = RouteController.extend({
  onBeforeAction: function (pause) {
    // reach around and fix the 'fromWhere'
    Meteor.setTimeout(function(){Session.set('fromWhere', '/dashboard')}, 1000) 
    AccountsEntry.signInRequired(this, pause)
  }
})

....you need to set the path for fromWhere to be where ever the user should go after logging in, typically the same url as the current controller handles.

It's not pretty as it works on the assumption that the user can't be redirected and sign-in in less than 1 second... but it fixes the user experience until I can upgrade to a 0.9 world... :squirrel:

[dkoo761]

@queso Can you let us know when the next accounts-entry release will be to fix this? I'm about to deploy my app into production and this is currently the only blocker left to resolve before we go live. If there is a temporary workaround, that would be fine too.

I've tried updating both the shared/router.coffee file and the various accounts-entry.js files in the .build directory of the accounts-entry package to implement @rgoomar 's fix but it seems like my update is being ignored even after restarting the Meteor server. I don't know much about fiddling with Meteor packages so maybe there's something special I need to do?

[fungilation]

+1. Correct redirect on hitting sign-in button once would be swell. Does Differential not use this package in their own apps, or they just don't update Meteor? I don't want to be ungrateful for Differential's great contributions to Meteor packages, but this has gone unfixed for a long time and an update on status of this package would be nice.

[ryw]

@hellogerard wanna take a look @ this?

@queso has transitioned out of Differential, so he'll be slightly less involved in our projects.

[queso]

Yeah, I am happy to take a look at this, but I can't really speak to what Differential is or isn't doing anymore.

[queso]

Actually, looks like I can't do much anymore, maybe @ryw or @hellogerard can help since I've lost my commit rights to open source stuff with Differential.

[ryw]

@queso permission restored :)

[hellogerard]

@ryw @queso I will defer, then.

[dkoo761]

Here's the workaround I'm currently using in case anyone else needs it. I'm using Iron Router but you could adapt it easily to work without it:

// in client code....
Meteor.startup(function () {
    Tracker.autorun(function () {
        if (Meteor.user() && Router.current() && Router.current().path === '/sign-in') {
            Router.go('home'); // change home to whatever route you want to take the user to after login
        }
    });
});