Skip to content

Conversation

sid597
Copy link
Collaborator

@sid597 sid597 commented Jun 22, 2025

Here is the result of using this function

image

Summary by CodeRabbit

  • New Features
    • Added the ability to fetch and display discourse nodes that have been edited since a specific date, including details such as author, timestamps, and content.

Copy link

linear bot commented Jun 22, 2025

Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discourse-graph ⬜️ Skipped (Inspect) Jun 22, 2025 10:31am

Copy link
Contributor

coderabbitai bot commented Jun 22, 2025

📝 Walkthrough

Walkthrough

A new utility function, getAllDiscourseNodesSince, has been added to fetch discourse nodes from a Roam Research graph that have been edited after a specified timestamp. This includes the introduction of a new exported type, DiscourseGraphContent, to structure the returned data.

Changes

File(s) Change Summary
apps/roam/src/utils/getAllDiscourseNodesSince.ts Added DiscourseGraphContent type and the getAllDiscourseNodesSince async function for querying and filtering discourse nodes since a given date.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant getAllDiscourseNodesSince
    participant RoamAPI
    participant isDiscourseNode

    Caller->>getAllDiscourseNodesSince: Call with "since" date string
    getAllDiscourseNodesSince->>RoamAPI: Query for blocks edited after timestamp
    RoamAPI-->>getAllDiscourseNodesSince: Return block data
    getAllDiscourseNodesSince->>isDiscourseNode: Check each block's source_local_id
    isDiscourseNode-->>getAllDiscourseNodesSince: Return boolean
    getAllDiscourseNodesSince-->>Caller: Return filtered discourse graph content array
Loading

Suggested reviewers

  • mdroidian

Poem

In the warren of code, a new path appears,
Fetching discourse nodes from recent years.
With timestamps and text, the data flows in,
Filtered by type, where discussions begin.
Now rabbits can query, with ears standing tall—
For knowledge since "then," just give it a call!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sid597
Copy link
Collaborator Author

sid597 commented Jun 22, 2025

@coderabbitai full review

Copy link
Contributor

coderabbitai bot commented Jun 22, 2025

✅ Actions performed

Full review triggered.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
apps/roam/src/utils/getAllDiscourseNodesSince.ts (1)

33-39: Add defensive programming and consider query optimization.

The filtering logic looks good, but consider these improvements:

  1. Add error handling for the isDiscourseNode function call
  2. The filtering could be moved to the Datalog query for better performance
  return result.filter(
    (entity) =>
      entity.source_local_id &&
-      isDiscourseNode(entity.source_local_id) &&
+      (() => {
+        try {
+          return isDiscourseNode(entity.source_local_id);
+        } catch (error) {
+          console.warn(`Error checking discourse node: ${entity.source_local_id}`, error);
+          return false;
+        }
+      })() &&
      entity.text &&
      entity.text.trim() !== "",
  );

Consider moving some filtering logic to the Datalog query itself to reduce the amount of data transferred and processed in JavaScript. For example, you could add conditions to filter out empty strings directly in the query.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0a6082 and 8fc0618.

📒 Files selected for processing (1)
  • apps/roam/src/utils/getAllDiscourseNodesSince.ts (1 hunks)
🔇 Additional comments (1)
apps/roam/src/utils/getAllDiscourseNodesSince.ts (1)

3-10: ```shell
#!/bin/bash

Display the contents of the utility to inspect the Datalog query and field mappings

sed -n '1,200p' apps/roam/src/utils/getAllDiscourseNodesSince.ts


</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@sid597 sid597 requested a review from mdroidian June 22, 2025 10:42
Copy link
Contributor

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested.

@sid597 sid597 requested a review from mdroidian June 26, 2025 11:50
@mdroidian mdroidian merged commit 314e9f5 into main Jun 26, 2025
4 checks passed
@mdroidian mdroidian deleted the eng-448-query-roam-discourse-nodes-created-or-modified-since-the-v2 branch June 26, 2025 18:22
@github-project-automation github-project-automation bot moved this to Done in General Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants