ENG-947 dragging and/or clicking on section header crashes the sidebar

[sid597]

Summary by CodeRabbit

• Bug Fixes

  • Sidebar configuration now stays in sync when initial settings change, preventing stale layouts.
  • Clicking a section title without sub-items no longer triggers unintended navigation.
  • Chevron actions only apply when a section has sub-items, reducing accidental clicks.

• Refactor

  • Simplified sidebar item click logic to make interactions more predictable and consistent.

[linear]

ENG-947 Bug report

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-947 dragging and/or clicking on section header crashes the sidebar #481 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

Need this to update the state of sections if we add new section or move the sections we want this to render that state

[mdroidian]

This is a bad pattern because it has two layers of state management, useConfig and useEffect.

Try this:
const { config, setConfig } = useConfig();

and modify useConfig() to also return setConfig
(and remove the useEffect)

[mdroidian]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates adjust click handling in PersonalSectionItem to only toggle when children exist and remove the fallback open action. LeftSidebarView gains an effect to synchronize local config state with changes to initialConfig by invoking setConfig(initialConfig).

Changes

Cohort / File(s)	Summary
Sidebar interactions and config sync apps/roam/src/components/LeftSidebarView.tsx	PersonalSectionItem: title onClick now calls handleChevronClick only when children exist; otherwise no action. LeftSidebarView: added useEffect to update config state whenever initialConfig changes via setConfig(initialConfig).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant PSI as PersonalSectionItem
  participant LSV as LeftSidebarView
  participant State as Config State

  rect rgba(200,230,255,0.3)
    note over PSI: Title click behavior
    User->>PSI: Click title
    alt Has children
      PSI->>PSI: handleChevronClick()
    else No children
      PSI-->>User: No action
    end
  end

  rect rgba(220,255,220,0.3)
    note over LSV,State: Sync initialConfig -> config
    LSV->>LSV: useEffect(dep: initialConfig)
    LSV->>State: setConfig(initialConfig)
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ENG-852 Render left sidebar based on fetched sections and settings #440 — Edits the same component areas: PersonalSectionItem event handling and config synchronization in LeftSidebarView.tsx.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the main issue addressed by the changeset, stating that dragging or clicking a section header crashes the sidebar, which directly corresponds to the bug fix implemented. It focuses on the primary change without extraneous details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a69b94e and 37c4a1e.

📒 Files selected for processing (1)

• apps/roam/src/components/LeftSidebarView.tsx (2 hunks)

🔇 Additional comments (2)

apps/roam/src/components/LeftSidebarView.tsx (2)

576-578: LGTM! State synchronization pattern is sound.

The effect correctly syncs local state with external config changes, supporting the use case described in the past comment (updating state when sections are added or moved). The pattern of maintaining local state for optimistic drag-drop updates while respecting external changes is appropriate.

Based on the past review comment from sid597.

---

221-225: Confirm leaf‐section navigation removal is intentional
Leaf sections no longer open on click and no alternative navigation exists—verify this UX change is intended.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mdroidian]

This is a bad pattern because it has two layers of state management, useConfig and useEffect.

Try this:
const { config, setConfig } = useConfig();

and modify useConfig() to also return setConfig
(and remove the useEffect)