Skip to content

ENG-298 repeat the sync at regular intervals #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 26, 2025
Merged

ENG-298 repeat the sync at regular intervals #513

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6fb89d2
ENG-298 isolate the repetition logic from the refactoring
maparent Oct 24, 2025
21aee0b
stop sync un unload
maparent Oct 24, 2025
e5fb5d0
Not finding the Space is not a reason not to sync; it will get create…
maparent Oct 24, 2025
9b6f096
reorder task preconditions, avoid ending a task that failed to start
maparent Oct 24, 2025
e6a44f0
clarify different interval values
maparent Oct 24, 2025
c3eae77
timing suggestions
maparent Oct 24, 2025
cee1023
coderabbit correction
maparent Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify different interval values
  • Loading branch information
@maparent
maparent committed Oct 24, 2025
commit e6a44f0583eb44500c368633fc5d78faee184a28
4 changes: 3 additions & 1 deletion apps/roam/src/utils/syncDgNodesToSupabase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ type LocalContentDataInput = Partial<CompositeTypes<"content_local_input">>;
type AccountLocalInput = CompositeTypes<"account_local_input">;

const SYNC_FUNCTION = "embedding";
// Minimal interval between syncs of all clients for this task.
const SYNC_INTERVAL = "45s";
// Interval between syncs for each client individually
const BASE_SYNC_INTERVAL = 5 * 60 * 1000; // 5 minutes
const SYNC_TIMEOUT = "20s";
const BATCH_SIZE = 200;
const DEFAULT_TIME = new Date("1970-01-01");
Expand Down Expand Up @@ -355,7 +358,6 @@ const upsertUsers = async (
}
};

const BASE_SYNC_INTERVAL = 5 * 60 * 1000; // 5 minutes
let doSync = true;
let numFailures = 0;
const MAX_FAILURES = 5;
Expand Down