FIX Check if lines are structured HTML before processing #36632
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Dec 15, 2025
| // Add lines substitution key from each line | ||
| $lines = ''; | ||
| $defaultlines = $arraydefaultmessage->content_lines; | ||
| $linesisstructuredhtml = false; |
Member
There was a problem hiding this comment.
This seems useless as this var is not used.
Only change at line 996 is required.
eldy
reviewed
Dec 15, 2025
| if (isset($defaultlines)) { | ||
| foreach ($this->substit_lines as $substit_line) { | ||
| $lines .= make_substitutions($defaultlines, $substit_line)."\n"; | ||
| $lines .= make_substitutions($defaultlines, $substit_line)."\n"; |
Member
There was a problem hiding this comment.
No need to change this line.You can restore the removed tabulation.
eldy
added
the
PR to fix - See feedback in comments
Removed unnecessary check for structured HTML in default lines.
Contributor
Author
|
solved |
eldy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines are created inline without formating