Skip to content

Restore the behaviour of --upload-fragment for acifragmentgen #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomAyre merged 26 commits into from
Dec 16, 2025
Merged

Restore the behaviour of --upload-fragment for acifragmentgen #13

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
18665a3
Remove the depedency on OPA
DomAyre Dec 10, 2025
74955ad
Bump version
DomAyre Dec 10, 2025
9b1a24f
Organise imports
DomAyre Dec 10, 2025
59162fe
Merge branch 'main' into remove-opa
DomAyre Dec 10, 2025
629c529
Restore default behaviour of --upload-fragment and give new args for …
DomAyre Sep 24, 2025
e5f138d
Add testing to enforce behaviour
DomAyre Sep 24, 2025
093cbd5
Test possible fixes for ado pipeline failure
DomAyre Sep 24, 2025
77e2461
Avoid using localhost for docker operations
DomAyre Sep 24, 2025
078fea2
Remove arg for TemporaryDirectory which is only in newer python version
DomAyre Sep 24, 2025
27f0ef4
Replace docker python SDK with CLI
DomAyre Sep 24, 2025
fa87416
Bump the version of confcom
DomAyre Sep 24, 2025
1093eed
Split fragment push and fragment attach into standalone tools
DomAyre Sep 25, 2025
c3cce05
Undo changes
DomAyre Sep 25, 2025
3e661d6
Print some debug info
DomAyre Sep 25, 2025
5c5a8bf
Add missing licenses
DomAyre Sep 25, 2025
4aef917
Handle case with attached fragments
DomAyre Sep 25, 2025
d23c671
Add fallback debug info
DomAyre Sep 25, 2025
d3c978f
Fix check
DomAyre Sep 25, 2025
6ff6395
Fix typo
DomAyre Sep 25, 2025
f82a9a4
Fix another typo
DomAyre Sep 25, 2025
f825e6f
Satisfy azdev linter
DomAyre Sep 26, 2025
5c0f27e
Fix azdev style
DomAyre Sep 26, 2025
3c90719
Fix missing import
DomAyre Nov 21, 2025
3a510cb
Fix race in tests
DomAyre Nov 25, 2025
62ad4f2
Prevent tests changing tracked files
DomAyre Nov 26, 2025
0de8ab7
Merge branch '16-12-25' into fix-upload-fragment
DomAyre Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove arg for TemporaryDirectory which is only in newer python version
  • Loading branch information
@DomAyre
DomAyre committed Dec 10, 2025
commit 078fea2491f8b49be5d68d53e91cbbaea1466cee
12 changes: 6 additions & 6 deletions src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def docker_image():

@pytest.fixture(scope="session")
def cert_chain():
with tempfile.TemporaryDirectory(delete=True) as temp_dir:
with tempfile.TemporaryDirectory() as temp_dir:
subprocess.run(
[
os.path.join(SAMPLES_DIR, "certs", "create_certchain.sh"),
Expand All @@ -75,7 +75,7 @@ def test_acifragmentgen_fragment_gen(docker_image):

image_ref, spec_file_path = docker_image

with tempfile.TemporaryDirectory(delete=True) as temp_dir: # Prevent test writing files to repo
with tempfile.TemporaryDirectory() as temp_dir: # Prevent test writing files to repo
acifragmentgen_confcom(
image_name=None,
tar_mapping_location=None,
Expand All @@ -99,7 +99,7 @@ def test_acifragmentgen_fragment_sign(docker_image, cert_chain):

image_ref, spec_file_path = docker_image

with tempfile.TemporaryDirectory(delete=True) as temp_dir: # Prevent test writing files to repo
with tempfile.TemporaryDirectory() as temp_dir: # Prevent test writing files to repo
acifragmentgen_confcom(
image_name=None,
tar_mapping_location=None,
Expand All @@ -121,7 +121,7 @@ def test_acifragmentgen_fragment_upload_fragment(docker_image, cert_chain):

image_ref, spec_file_path = docker_image

with tempfile.TemporaryDirectory(delete=True) as temp_dir: # Prevent test writing files to repo
with tempfile.TemporaryDirectory() as temp_dir: # Prevent test writing files to repo
acifragmentgen_confcom(
image_name=None,
tar_mapping_location=None,
Expand Down Expand Up @@ -153,7 +153,7 @@ def test_acifragmentgen_fragment_push(docker_image, cert_chain):
image_ref, spec_file_path = docker_image
fragment_ref = image_ref.replace("hello-world", "fragment")

with tempfile.TemporaryDirectory(delete=True) as temp_dir: # Prevent test writing files to repo
with tempfile.TemporaryDirectory() as temp_dir: # Prevent test writing files to repo
acifragmentgen_confcom(
image_name=None,
tar_mapping_location=None,
Expand Down Expand Up @@ -182,7 +182,7 @@ def test_acifragmentgen_fragment_attach(docker_image, cert_chain):

image_ref, spec_file_path = docker_image

with tempfile.TemporaryDirectory(delete=True) as temp_dir: # Prevent test writing files to repo
with tempfile.TemporaryDirectory() as temp_dir: # Prevent test writing files to repo
acifragmentgen_confcom(
image_name=None,
tar_mapping_location=None,
Expand Down