Skip to content

Conversation

@Nathon2Y
Copy link
Contributor

@Nathon2Y Nathon2Y commented Dec 2, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Feat: 添加children覆盖UI渲染,listenerOptions传入监听器参数

🇺🇸 English

  • Feat: add children prop to change UI, listenerOptions to pass listener params

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14bd943:

Sandbox Source
pr-story Configuration

const { hotKeys, content, onClick, render, getListenerTarget, className, style, ...rest } = this.props;
const { children, hotKeys, content, onClick, render, getListenerTarget, className, style, ...rest } = this.props;

if (children) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的代码可以简写吗

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个 return 的 jsx props 都是一样的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants