Skip to content

fix: [Toast][Notification] Fixed a TypeError issue that occurred on the first Toast/Notification imperative call in React v19 #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YannLynn merged 2 commits into from
Dec 5, 2025
Merged

fix: [Toast][Notification] Fixed a TypeError issue that occurred on the first Toast/Notification imperative call in React v19 #3053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e39ff79
fix: [Toast][Notification] Fixed a TypeError issue that occurred on t…
YyumeiZhang Nov 25, 2025
94700d4
fix: [Toast][Notification] Fixed a TypeError issue that occurred on t…
YyumeiZhang Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions packages/semi-ui/notification/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ const defaultConfig = {
zIndex: 1010,
};

/* REACT_19_START */
// const notificationQueue: Array<{ notice: NoticeProps; id: string }> = [];
/* REACT_19_END */

class NotificationList extends BaseComponent<NotificationListProps, NotificationListState> {
static contextType = ConfigContext;
static propTypes = {
Expand Down Expand Up @@ -133,16 +137,19 @@ class NotificationList extends BaseComponent<NotificationListProps, Notification
// if (!this.root) {
// this.root = createRoot(div);
// }
// this.root.render(React.createElement(NotificationList, { ref: instance => (ref = instance) }));
// // 在 React 19 中，render 是同步的，确保 ref 已赋值后再执行add方法
// if (typeof queueMicrotask === 'function') {
// queueMicrotask(() => {
// ref.add({ ...notice, id });
// });
// this.root.render(React.createElement(NotificationList, {
// ref: instance => {
// ref = instance;
// while (notificationQueue.length && ref && typeof ref.add === 'function') {
// const { notice: queuedNotice, id: queuedId } = notificationQueue.shift();
// ref.add({ ...queuedNotice, id: queuedId });
// }
// }
// }));
// if (ref && typeof ref.add === 'function') {
// ref.add({ ...notice, id });
// } else {
// Promise.resolve().then(() => {
// ref.add({ ...notice, id });
// });
// notificationQueue.push({ notice, id });
// }
/* REACT_19_END */
} else {
Expand Down
36 changes: 22 additions & 14 deletions packages/semi-ui/toast/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ const createBaseToast = () => class ToastList extends BaseComponent<ToastListPro
zIndex: 1010,
content: '',
};

/* REACT_19_START */
// static toastQueue: Array<{ opts: ToastReactProps, id: string }> = [];
/* REACT_19_END */

static propTypes = {
content: PropTypes.node,
duration: PropTypes.number,
Expand Down Expand Up @@ -146,19 +151,22 @@ const createBaseToast = () => class ToastList extends BaseComponent<ToastListPro
// }
// this.root.render(React.createElement(
// ToastList,
// { ref: instance => (ToastList.ref = instance) }
// { ref: instance => {
// ToastList.ref = instance;
// // New: flush toast queue after ref ready
// while (ToastList.toastQueue.length && ToastList.ref && typeof ToastList.ref.add === 'function') {
// const { opts: queuedOpts, id: queuedId } = ToastList.toastQueue.shift();
// ToastList.ref.add({ ...queuedOpts, id: queuedId });
// ToastList.ref.stack = Boolean(queuedOpts.stack);
// }
// } }
// ));
// // 在 React 19 中，render 是同步的，确保 ref 已赋值后再执行add方法
// if (typeof queueMicrotask === 'function') {
// queueMicrotask(() => {
// ToastList.ref.add({ ...opts, id });
// ToastList.ref.stack = Boolean(opts.stack);
// });
// if (ToastList.ref && typeof ToastList.ref.add === 'function') {
// ToastList.ref.add({ ...opts, id });
// ToastList.ref.stack = Boolean(opts.stack);
// } else {
// Promise.resolve().then(() => {
// ToastList.ref.add({ ...opts, id });
// ToastList.ref.stack = Boolean(opts.stack);
// });
// ToastList.toastQueue.push({ opts, id });
// }
/* REACT_19_END */
} else {
Expand Down Expand Up @@ -298,11 +306,11 @@ const createBaseToast = () => class ToastList extends BaseComponent<ToastListPro
[`${cssClasses.PREFIX}-innerWrapper`]: true,
[`${cssClasses.PREFIX}-innerWrapper-hover`]: this.state.mouseInSide
})} ref={this.innerWrapperRef} onMouseEnter={this.handleMouseEnter} onMouseLeave={this.handleMouseLeave}>
{list.map((item, index) =>{
const isRemoved = removedItems.find(removedItem=>removedItem.id===item.id) !== undefined;
return <CSSAnimation key={item.id} motion={item.motion} animationState={isRemoved?"leave":"enter"} startClassName={isRemoved?`${cssClasses.PREFIX}-animation-hide`:`${cssClasses.PREFIX}-animation-show`}>
{list.map((item, index) => {
const isRemoved = removedItems.find(removedItem => removedItem.id === item.id) !== undefined;
return <CSSAnimation key={item.id} motion={item.motion} animationState={isRemoved ? "leave" : "enter"} startClassName={isRemoved ? `${cssClasses.PREFIX}-animation-hide` : `${cssClasses.PREFIX}-animation-show`}>
{
({ animationClassName, animationEventsNeedBind, isAnimating })=>{
({ animationClassName, animationEventsNeedBind, isAnimating }) => {
return (isRemoved && !isAnimating) ? null : <Toast {...item} stack={this.stack} stackExpanded={this.state.mouseInSide} positionInList={{ length: list.length, index }} className={cls({
[item.className]: Boolean(item.className),
[animationClassName]: true
Expand Down
Loading