remove LocalPath and rename Origin to HostHeaderValue#2208
Conversation
3c8f4d0 to
7d6f62b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR renames several confusing terminology throughout the BFF codebase to improve clarity and reduce confusion around domain-specific concepts:
- LocalPath → PathMatch: Clarifies that this represents a path pattern for matching rather than a filesystem path
- Origin → HostHeaderValue: Distinguishes from HTTP origin headers and CORS concepts while better describing the actual data structure (scheme + host + port)
- MappedToOrigin/MappedToPath → MapTo/MapToHost/MapToPath: Changes from passive "mapped to" language to imperative "map to" verbs
- SelectionCriteria → MatchingCriteria: More clearly describes the purpose of determining frontend selection
- FrontendSelectionCriteria → FrontendMatchingCriteria: Aligns with the above naming convention
Reviewed Changes
Copilot reviewed 54 out of 55 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Test infrastructure files | Update test data builders and configuration to use new terminology |
| Public API verification files | Update expected public API surface to reflect terminology changes |
| Template files | Update configuration examples to use PathString instead of LocalPath |
| Core BFF source files | Rename types, properties, and methods throughout the codebase |
| Documentation | Update upgrade guide to reflect API changes |
| Performance/benchmark files | Update test hosts and fixtures with new terminology |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7d6f62b to
2cd20d6
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 56 out of 57 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2f44af9 to
648113a
Compare
648113a to
2f44af9
Compare
2f44af9 to
f419b2c
Compare
- Also allow '/' as default frontend - Raise warnings on duplicate frontend selection criteria # Conflicts: # bff/hosts/Hosts.Bff.MultiFrontend/Program.cs # bff/src/Bff/DynamicFrontends/BffFrontend.cs # bff/test/Bff.Tests/Configuration/BffBuilderTests.cs # bff/test/Bff.Tests/PublicApiVerificationTests.VerifyPublicApi_Bff.verified.txt # bff/test/Bff.Tests/TestInfra/TestDataBuilder.cs
f419b2c to
f9b3096
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 60 out of 61 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f8415f2 to
118f75c
Compare
What issue does this PR address?
There's confusion around certain terms:
fixes: https://github.com/DuendeSoftware/products-private/issues/2272
fixes: https://github.com/DuendeSoftware/products-private/issues/2357
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)