Skip to content

setData + getData functions#53

Merged
frozeman merged 12 commits intoERC725Alliance:masterfrom
YamenMerhi:master
Sep 7, 2021
Merged

setData + getData functions#53
frozeman merged 12 commits intoERC725Alliance:masterfrom
YamenMerhi:master

Conversation

@YamenMerhi
Copy link
Collaborator

@YamenMerhi YamenMerhi commented Sep 3, 2021

Description

Changed the setData and the getData functions in the ERC725Y contract.

@frozeman , @CJ42 and I found that the better way to setData is by passing an array of data which can be set in one transaction, that way we can skip the need to to make a contract call each time we want to set singular form of data. Same applies for getData.

Changes

  • Added Arrays parameters to the setData , getData functions in ERC725YCore.sol , ERC725Y.sol , ERC725YInit.sol and IERC725Y.sol
  • Edited the docs.
  • Changed the ERC165 interface Id.
  • Added a require statement in setData function
  • Optimized getData function
  • Added 2 dummy contracts used for tests to ./helpers
  • Added Tests covering changed functions.

@YamenMerhi YamenMerhi changed the title setDataMultiple + getDataMultiple functions setData + getData functions Sep 4, 2021
@frozeman frozeman merged commit 33ca829 into ERC725Alliance:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants