Skip to content

[DMS-878] Disable auth #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
axelmarquezh wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DMS-878] Disable auth #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dms/backend/EdFi.DataManagementService.Backend.Postgresql/DocumentAuthorizationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public static class DocumentAuthorizationHelper
ISqlAction sqlAction
)
{
return (null, null, null, null);

// Extract security elements and authorization info based on request type
var (securityElements, authInfo) = request switch
{
Expand Down
21 changes: 0 additions & 21 deletions src/dms/backend/EdFi.DataManagementService.Backend.Postgresql/Model/Document.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,6 @@ public record Document(
/// </summary>
JsonElement EdfiDoc,
/// <summary>
/// The security elements extracted from the document
/// </summary>
JsonElement SecurityElements,
/// <summary>
/// Array of EducationOrganizationIds through StudentSchoolAssociation
/// </summary>
JsonElement? StudentSchoolAuthorizationEdOrgIds,
/// <summary>
/// Array of EducationOrganizationIds through StudentEducationOrganizationResponsibilityAssociation
/// </summary>
JsonElement? StudentEdOrgResponsibilityAuthorizationIds,
/// <summary>
/// Array of EducationOrganizationIds through StudentContactAssociation
/// </summary>
JsonElement? ContactStudentSchoolAuthorizationEdOrgIds,
/// <summary>
/// Array of EducationOrganizationIds through StaffEducationOrganizationEmploymentAssociation
/// or StaffEducationOrganizationAssignmentAssociation
/// </summary>
JsonElement? StaffEducationOrganizationAuthorizationEdOrgIds,
/// <summary>
/// The correlation id of the last insert or update
/// </summary>
string LastModifiedTraceId,
Expand Down
4 changes: 0 additions & 4 deletions src/dms/backend/EdFi.DataManagementService.Backend.Postgresql/Model/DocumentSummary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ public record DocumentSummary(
/// </summary>
JsonElement EdfiDoc,
/// <summary>
/// The SecurityElements JSON field from the database
/// </summary>
JsonElement SecurityElements,
/// <summary>
/// The datetime this document was last modified in the database
/// </summary>
DateTime LastModifiedAt,
Expand Down
27 changes: 0 additions & 27 deletions ...dms/backend/EdFi.DataManagementService.Backend.Postgresql/Operation/DeleteDocumentById.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,33 +60,6 @@ NpgsqlTransaction transaction
return new DeleteResult.DeleteFailureETagMisMatch();
}

var securityElements = documentSummary.SecurityElements.ToDocumentSecurityElements()!;

var deleteAuthorizationResult = await deleteRequest.ResourceAuthorizationHandler.Authorize(
securityElements,
OperationType.Delete,
deleteRequest.TraceId
);

if (deleteAuthorizationResult is ResourceAuthorizationResult.NotAuthorized notAuthorized)
{
return new DeleteResult.DeleteFailureNotAuthorized(notAuthorized.ErrorMessages);
}

if (deleteRequest.DeleteInEdOrgHierarchy && documentSummary.DocumentId != null)
{
long documentId = documentSummary.DocumentId.Value;

await _sqlAction.DeleteEducationOrganizationHierarchy(
deleteRequest.ResourceInfo.ProjectName.Value,
deleteRequest.ResourceInfo.ResourceName.Value,
documentId,
documentPartitionKey.Value,
connection,
transaction
);
}

int rowsAffectedOnDocumentDelete = await _sqlAction.DeleteDocumentByDocumentUuid(
documentPartitionKey,
deleteRequest.DocumentUuid,
Expand Down
21 changes: 0 additions & 21 deletions src/dms/backend/EdFi.DataManagementService.Backend.Postgresql/Operation/GetDocumentById.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,27 +53,6 @@ public async Task<GetResult> GetById(
return new GetResult.GetFailureNotExists();
}

var securityElements = documentSummary.SecurityElements.ToDocumentSecurityElements()!;

ResourceAuthorizationResult getAuthorizationResult =
await getRequest.ResourceAuthorizationHandler.Authorize(
securityElements,
OperationType.Get,
getRequest.TraceId
);

if (getAuthorizationResult is ResourceAuthorizationResult.NotAuthorized notAuthorized)
{
if (notAuthorized is ResourceAuthorizationResult.NotAuthorized.WithHint notAuthorizedWithHint)
{
return new GetResult.GetFailureNotAuthorized(
notAuthorizedWithHint.ErrorMessages,
notAuthorizedWithHint.Hints
);
}
return new GetResult.GetFailureNotAuthorized(notAuthorized.ErrorMessages);
}

return new GetResult.GetSuccess(
getRequest.DocumentUuid,
documentSummary.EdfiDoc.Deserialize<JsonNode>()!,
Expand Down
Loading
Loading