Skip to content

[DMS-884] .Net 10 migration #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simpat-adam wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[DMS-884] .Net 10 migration #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb6bf27
.Net 10 Migration
simpat-adam Dec 15, 2025
31805c9
Fix issue due to form binding change
simpat-adam Dec 15, 2025
a629d26
Code scanning fixes
simpat-adam Dec 15, 2025
b2d38e6
Test fixups
simpat-adam Dec 15, 2025
7a6cdf3
Fix SDK generator .net target
simpat-adam Dec 15, 2025
4fc42c4
Fix SDK generator .net target
simpat-adam Dec 15, 2025
570b97f
switched to the newer Alpine 3.23 base image
simpat-adam Dec 15, 2025
1256497
Pin SHA digests
simpat-adam Dec 16, 2025
1e07b98
Remove working scratchpad
simpat-adam Dec 16, 2025
2d87d38
Re-pin alpine packages
simpat-adam Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Dependency Review ("Dependabot on PR")
if: ${{ github.event_name == 'pull_request' && !github.event.repository.fork }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-cli-generator-pullrequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-cli-generator.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/on-config-pullrequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Build
run: ./build-config.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Build
run: ./build-config.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Build
run: ./build-config.ps1 Build -Configuration ${{ env.CONFIGURATION }} -IdentityProvider ${{matrix.identityprovider}}
Expand All @@ -178,7 +178,7 @@ jobs:
with:
name: test-logs
path: |
./src/services/EdFi.DmsConfigurationService.Api.Tests.E2E/bin/Release/net8.0/logs
./src/services/EdFi.DmsConfigurationService.Api.Tests.E2E/bin/Release/net10.0/logs
retention-days: 10

- name: Upload Test Results
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/on-dms-pullrequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }} -IdentityProvider ${{matrix.identityprovider}}
Expand Down Expand Up @@ -287,7 +287,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down Expand Up @@ -395,7 +395,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/on-prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Set DMS Version Numbers
id: versions
Expand Down Expand Up @@ -344,7 +344,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Set Config Version Numbers
id: versions
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scheduled-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Cache Nuget packages
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Build
run: ./build-dms.ps1 Build -Configuration ${{ env.CONFIGURATION }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scheduled-pre-image-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: '8.0.x'
dotnet-version: '10.0.x'

- name: Cache Nuget packages
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 #v4.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scheduled-smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@87b7050bc53ea08284295505d98d2aa94301e852 # v4.2
with:
dotnet-version: "8.0.x"
dotnet-version: "10.0.x"

- name: Cache NuGet packages
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2
Expand Down
4 changes: 2 additions & 2 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"type": "coreclr",
"request": "launch",
"preLaunchTask": "DMS",
"program": "${workspaceFolder}\\src\\dms\\frontend\\EdFi.DataManagementService.Frontend.AspNetCore\\bin\\Debug\\net8.0\\EdFi.DataManagementService.Frontend.AspNetCore.dll",
"program": "${workspaceFolder}\\src\\dms\\frontend\\EdFi.DataManagementService.Frontend.AspNetCore\\bin\\Debug\\net10.0\\EdFi.DataManagementService.Frontend.AspNetCore.dll",
"args": [],
"cwd": "${workspaceFolder}\\src\\dms\\frontend\\EdFi.DataManagementService.Frontend.AspNetCore",
"stopAtEntry": false,
Expand All @@ -28,7 +28,7 @@
"type": "coreclr",
"request": "launch",
"preLaunchTask": "Config",
"program": "${workspaceFolder}\\src\\config\\frontend\\EdFi.DmsConfigurationService.Frontend.AspNetCore\\bin\\Debug\\net8.0\\EdFi.DmsConfigurationService.Frontend.AspNetCore.dll",
"program": "${workspaceFolder}\\src\\config\\frontend\\EdFi.DmsConfigurationService.Frontend.AspNetCore\\bin\\Debug\\net10.0\\EdFi.DmsConfigurationService.Frontend.AspNetCore.dll",
"args": [],
"cwd": "${workspaceFolder}\\src\\config\\frontend\\EdFi.DmsConfigurationService.Frontend.AspNetCore",
"stopAtEntry": false,
Expand Down
4 changes: 2 additions & 2 deletions build-cli-generator.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function RunTests {
$Filter
)

$testAssemblyPath = "$solutionRoot/$Filter/bin/$Configuration/net8.0/"
$testAssemblyPath = "$solutionRoot/$Filter/bin/$Configuration/net10.0/"
$testAssemblies = Get-ChildItem -Path $testAssemblyPath -Filter "$Filter.dll" -ErrorAction SilentlyContinue |
Sort-Object -Property { $_.Name.Length }

Expand Down Expand Up @@ -263,7 +263,7 @@ function RunSchemaGenerator {
$Arguments
)

$exePath = "$cliProjectRoot/bin/$Configuration/net8.0/$projectName.exe"
$exePath = "$cliProjectRoot/bin/$Configuration/net10.0/$projectName.exe"

if (!(Test-Path $exePath)) {
Write-Warning "Schema Generator CLI executable not found at $exePath"
Expand Down
2 changes: 1 addition & 1 deletion eng/CmsHierarchy/CmsHierarchy.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions eng/sdkGen/EdFi.DmsApi.Sdk.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<copyright>Copyright @ $year$ Ed-Fi Alliance, LLC and Contributors</copyright>
<tags>Ed-Fi Data Management Service SDK</tags>
<dependencies>
<group targetFramework="net8.0">
<group targetFramework="net10.0">
<dependency id="NewtonSoft.Json" version="13.0.3" />
<dependency id="JsonSubTypes" version="2.0.1" />
<dependency id="RestSharp" version="112.0.0" />
Expand All @@ -23,6 +23,6 @@
</metadata>
<files>
<file src="readme.txt" target="" />
<file src="csharp\src\EdFi.DmsApi.Sdk\bin\Release\net8.0\EdFi.DmsApi.Sdk.dll" target="lib\net8.0" />
<file src="csharp\src\EdFi.DmsApi.Sdk\bin\Release\net10.0\EdFi.DmsApi.Sdk.dll" target="lib\net10.0" />
</files>
</package>
4 changes: 2 additions & 2 deletions eng/sdkGen/EdFi.DmsApi.TestSdk.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<copyright>Copyright @ $year$ Ed-Fi Alliance, LLC and Contributors</copyright>
<tags>Ed-Fi Data Management Service TestSdk</tags>
<dependencies>
<group targetFramework="net8.0">
<group targetFramework="net10.0">
<dependency id="NewtonSoft.Json" version="13.0.3" />
<dependency id="JsonSubTypes" version="2.0.1" />
<dependency id="RestSharp" version="112.0.0" />
Expand All @@ -23,6 +23,6 @@
</metadata>
<files>
<file src="readme.txt" target="" />
<file src="csharp\src\EdFi.DmsApi.TestSdk\bin\Release\net8.0\EdFi.DmsApi.TestSdk.dll" target="lib\net8.0" />
<file src="csharp\src\EdFi.DmsApi.TestSdk\bin\Release\net10.0\EdFi.DmsApi.TestSdk.dll" target="lib\net10.0" />
</files>
</package>
40 changes: 20 additions & 20 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Handlebars.Net" Version="2.1.6" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.1" />
<PackageVersion Include="AspNetCore.HealthChecks.NpgSql" Version="8.0.2" />
<PackageVersion Include="Be.Vlaanderen.Basisregisters.Generators.Guid.Deterministic" Version="4.0.0" />
<PackageVersion Include="CommandLineParser" Version="2.9.1" />
Expand All @@ -17,10 +17,11 @@
<PackageVersion Include="EdFi.TPDM.ApiSchema" Version="1.0.300" />
<PackageVersion Include="FastGuid" Version="1.4.1" />
<PackageVersion Include="Keycloak.Net.Core" Version="1.0.29" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.8" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="10.0.1" />
<PackageVersion Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
<PackageVersion Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.2.0" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.9" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="10.0.1" />
<PackageVersion Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.12.0" />
<PackageVersion Include="Microsoft.IdentityModel.Protocols" Version="8.12.0" />
<PackageVersion Include="Microsoft.IdentityModel.Tokens" Version="8.12.0" />
Expand All @@ -35,18 +36,17 @@
<PackageVersion Include="System.IdentityModel.Tokens.Jwt" Version="8.12.0" />
<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="4.11.0" />
<PackageVersion Include="Microsoft.Extensions.Caching.Abstractions" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Caching.Abstractions" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.1" />
<PackageVersion Include="Npgsql" Version="8.0.4" />
<PackageVersion Include="Npgsql.DependencyInjection" Version="8.0.3" />
<PackageVersion Include="NuGet.Configuration" Version="6.13.1" />
Expand All @@ -55,7 +55,7 @@
<PackageVersion Include="Polly" Version="8.5.2" />
<PackageVersion Include="Polly.Core" Version="8.4.2" />
<PackageVersion Include="Polly.Extensions" Version="8.4.2" />
<PackageVersion Include="Respawn" Version="6.2.1" />
<PackageVersion Include="Respawn" Version="7.0.0" />
<PackageVersion Include="Sandwych.QuickGraph.Core" Version="1.0.0" />
<PackageVersion Include="Serilog" Version="4.0.2" />
<PackageVersion Include="Serilog.Extensions.Logging" Version="8.0.0" />
Expand All @@ -78,10 +78,10 @@
<PackageVersion Include="FakeItEasy" Version="8.3.0" />
<PackageVersion Include="FluentAssertions" Version="6.12.1" />
<PackageVersion Include="ImpromptuInterface" Version="8.0.4" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.8" />
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="9.0.1" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="10.0.1" />
<PackageVersion Include="Microsoft.Playwright.NUnit" Version="1.46.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageVersion Include="NUnit" Version="4.2.2" />
Expand Down
4 changes: 2 additions & 2 deletions src/config/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# The Ed-Fi Alliance licenses this file to you under the Apache License, Version 2.0.
# See the LICENSE and NOTICES files in the project root for more information.

FROM mcr.microsoft.com/dotnet/sdk:8.0.401-alpine3.20@sha256:658c93223111638f9bb54746679e554b2cf0453d8fb7b9fed32c3c0726c210fe AS build
FROM mcr.microsoft.com/dotnet/sdk:10.0-alpine@sha256:0fba99926e4f12405c78f37941312f00c1aadb178bd63616f5d96fc2af5a26a9 AS build

WORKDIR /source
# Named context support https://github.com/hadolint/hadolint/issues/830
Expand Down Expand Up @@ -31,7 +31,7 @@ COPY datamodel/EdFi.DmsConfigurationService.DataModel/ ./datamodel/EdFi.DmsConfi
RUN dotnet publish frontend/EdFi.DmsConfigurationService.Frontend.AspNetCore/EdFi.DmsConfigurationService.Frontend.AspNetCore.csproj \
-c Release --no-restore --self-contained false -o /app/Frontend

FROM mcr.microsoft.com/dotnet/aspnet:8.0.12-alpine3.21@sha256:accc7352721d44ef6246e91704f4efb1954f69912af2d2bd54d117fa09922a53 AS runtimebase
FROM mcr.microsoft.com/dotnet/aspnet:10.0-alpine3.23@sha256:900e8fc49fe97a7a8d9134612438d33c5c0e943dae8081b060054093d16e6ab4 AS runtimebase

# bash: used in startup script and debugging
# postgresql: used to test for PostgreSQL readiness
Expand Down
2 changes: 1 addition & 1 deletion src/config/Nuget.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ FROM mcr.microsoft.com/dotnet/aspnet:8.0.12-alpine3.21@sha256:accc7352721d44ef62

LABEL maintainer="Ed-Fi Alliance, LLC and Contributors <[email protected]>"

RUN apk --no-cache add postgresql16-client=~16
RUN apk --no-cache add postgresql16-client

FROM runtimebase AS setup

Expand Down
2 changes: 1 addition & 1 deletion ...figurationService.Backend.Installer/EdFi.DmsConfigurationService.Backend.Installer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...onfigurationService.Backend.Keycloak/EdFi.DmsConfigurationService.Backend.Keycloak.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/config/backend/EdFi.DmsConfigurationService.Backend.Keycloak/KeycloakClientRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async Task<ClientCreateResult> CreateClientAsync(
}

logger.LogError(
$"Error while creating the client: {clientId}. CreateClientAndRetrieveClientIdAsync returned empty string with no exception."
Copy link
Contributor Author

@simpat-adam simpat-adam Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github advanced security bot made me remove this.

"Error while creating the client. CreateClientAndRetrieveClientIdAsync returned empty string with no exception."
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message no longer includes the clientId variable, making it harder to identify which client failed during troubleshooting. Consider including the clientId in the error message.

Suggested change
"Error while creating the client. CreateClientAndRetrieveClientIdAsync returned empty string with no exception."
$"Error while creating the client '{clientId}'. CreateClientAndRetrieveClientIdAsync returned empty string with no exception."

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@simpat-adam simpat-adam Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because nothing would satisfy the github-advanced-security bot in my attempts to sanitize the input.

);
return new ClientCreateResult.FailureUnknown($"Error while creating the client: {clientId}");
}
Expand Down Expand Up @@ -319,7 +319,7 @@ public async Task<ClientUpdateResult> UpdateClientAsync(
else
{
var scopeNotFound = $"Scope {scope} not found";
logger.LogError(message: scopeNotFound);
logger.LogError("Specified scope not found");
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message no longer includes the specific scope name that was not found, making debugging more difficult. Consider keeping the scope variable in the message.

Suggested change
logger.LogError("Specified scope not found");
logger.LogError("Specified scope not found: {Scope}", scope);

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@simpat-adam simpat-adam Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because nothing would satisfy the github-advanced-security bot in my attempts to sanitize the input.

return new ClientUpdateResult.FailureIdentityProvider(
new IdentityProviderError(scopeNotFound)
);
Expand Down
2 changes: 1 addition & 1 deletion ...i.DmsConfigurationService.Backend.Mssql/EdFi.DmsConfigurationService.Backend.Mssql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...gurationService.Backend.OpenIddict/EdFi.DmsConfigurationService.Backend.OpenIddict.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
Loading
Loading