-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add My Profile : kiritocode1.json #1897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
| Welcome @kiritocode1! Thank you so much for your first pull request! |
| Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest. |
EmmaDawsonDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your profile looks good but you accidentally committed the package lock file. Please use git revert to remove it from your commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes are required in package-lock.json for adding your profile! You can follow this step by step guide to revert the changes from lock file.
Let us know if you need any help with this! :)
kumarsonsoff3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, you've deleted the lock file! You're only required to revert the changes from package-lock file.
Just do one thing, copy the whole content from main package-lock file, and paste it in that of your fork!
If you run with any issues, feel free to reach us out!
|
How are you getting on with this @kiritocode1 ? |
|
Sorry @EmmaDawsonDev , i went on a break, ill get back to it monday, |
|
No problem at all, just wanted to check in 😊 |
This PR Proposes Changes to
/public/dataChanges Proposed to
Added kiritocode1.json to the directory
/public/data.Check List
Screenshots
#Note :
please review and merge this PR , Love you 😄