-
-
Notifications
You must be signed in to change notification settings - Fork 439
IRC Ghost 12 bit support #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRC Ghost 12 bit support #1233
Conversation
|
This hasn't turned into a PR for OTX just yet because @tonycake is still finalysing some tweaks, there might still be changes |
|
Thanks for the update... would take a while over here anywhere as it needs some devs and/or users with ghost hardware test it before merge ;) |
|
For this PR to be complete, I think we should add some YAML-specific stuff, so that the config is more explicit. |
|
Green light from Tony :) |
a470b58 to
0d4ee8b
Compare
f9adcbe to
1829a90
Compare
1829a90 to
2b52caf
Compare
2b52caf to
b3a1f9f
Compare
b3a1f9f to
7621171
Compare
7621171 to
bf053d6
Compare
|
The changes I made introduce a more explicit module configuration: moduleData:
1:
type: TYPE_GHOST
subType: 0
channelsStart: 0
channelsCount: 16
failsafeMode: NOT_SET
mod:
ghost:
raw12bits: 1 |
And added the "ghost" union member to the selector.
bf053d6 to
257d25b
Compare
|
Can I get an update on this status on this PR, as given have zero Ghost hardware inability to test it... is it working for you guys? If so, Given the update by Raphael I suspect it's ready to merge. |
|
@pfeerick It is working for me but I would like to hear that also from someone not interested (independent) in this PR. |
|
@pfeerick @daleckystepan everything works as it should for me, with #1377 it's perfect. |
pfeerick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's enough grounds for me to subject tomorrows nightly users to it for further testing ;)
|
Perfect |
Summary of changes:
Benefits:
Fixes:
Betaflight PR
betaflight/betaflight#10801
OpenTx commit about this
opentx/opentx@0b699e6
Thanks @tonycake for support and help. @3djc for OpenTx implementation.