Skip to content

Conversation

@daleckystepan
Copy link
Contributor

@daleckystepan daleckystepan commented Dec 8, 2021

Summary of changes:

  • Add 4 new frames with scaling that supports up to 12bit resolution (currently it transfers 11bit -1024:1024 as EdgeTx provides)
  • Add checkbox in model setup menu to enable/disable new 12 bit mode.
  • BF 4.3 and Ghost FW V1.0.5.2+ is needed.

Benefits:

  • smoother feedforward
  • smoother flight

Fixes:

  • truncation errors with old scaling

Betaflight PR
betaflight/betaflight#10801

OpenTx commit about this
opentx/opentx@0b699e6

Thanks @tonycake for support and help. @3djc for OpenTx implementation.

@3djc
Copy link
Collaborator

3djc commented Dec 9, 2021

This hasn't turned into a PR for OTX just yet because @tonycake is still finalysing some tweaks, there might still be changes

@pfeerick
Copy link
Member

pfeerick commented Dec 9, 2021

Thanks for the update... would take a while over here anywhere as it needs some devs and/or users with ghost hardware test it before merge ;)

@raphaelcoeffic
Copy link
Member

For this PR to be complete, I think we should add some YAML-specific stuff, so that the config is more explicit.

@3djc
Copy link
Collaborator

3djc commented Dec 10, 2021

Green light from Tony :)

@raphaelcoeffic
Copy link
Member

@daleckystepan

The changes I made introduce a more explicit module configuration:

moduleData: 
   1:
      type: TYPE_GHOST
      subType: 0
      channelsStart: 0
      channelsCount: 16
      failsafeMode: NOT_SET
      mod: 
         ghost: 
            raw12bits: 1

daleckystepan and others added 2 commits January 22, 2022 13:43
And added the "ghost" union member to the selector.
@pfeerick
Copy link
Member

pfeerick commented Jan 25, 2022

Can I get an update on this status on this PR, as given have zero Ghost hardware inability to test it... is it working for you guys? If so, Given the update by Raphael I suspect it's ready to merge.

@pfeerick pfeerick self-assigned this Jan 25, 2022
@daleckystepan
Copy link
Contributor Author

@pfeerick It is working for me but I would like to hear that also from someone not interested (independent) in this PR.

@TheIsotopes
Copy link
Contributor

@pfeerick @daleckystepan everything works as it should for me, with #1377 it's perfect.

Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's enough grounds for me to subject tomorrows nightly users to it for further testing ;)

@daleckystepan
Copy link
Contributor Author

Perfect

@pfeerick pfeerick merged commit 4b93686 into EdgeTX:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants