Skip to content

Fix Tracer.currentOtelSpan to work with OTLP module #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 5 commits into from
Dec 13, 2025
+155 −9
Merged

Fix Tracer.currentOtelSpan to work with OTLP module #5890

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a19ff3
Fix Tracer.currentOtelSpan to work with OTLP module
schickling Dec 10, 2025
3270a28
proxy
tim-smart Dec 10, 2025
e4f3bac
wip
tim-smart Dec 10, 2025
88b468b
prefer BigInt constructor
tim-smart Dec 10, 2025
840371a
update docs
tim-smart Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@tim-smart
tim-smart committed Dec 10, 2025
commit e4f3bac5341ea718e4d8d976ac2735e6d71ce854
10 changes: 3 additions & 7 deletions packages/opentelemetry/src/internal/tracer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,9 @@ const makeOtelSpan = (span: EffectTracer.Span, clock: Clock.Clock): OtelApi.Span
return self
},
setStatus(status) {
if (span.status._tag === "Started" || status.code === OtelApi.SpanStatusCode.UNSET) {
return self
}
exit = OtelApi.SpanStatusCode.OK
? Exit.void
: Exit.die(status.message ?? "Unknown error")
exit = OtelApi.SpanStatusCode.ERROR
? Exit.die(status.message ?? "Unknown error")
: Exit.void
return self
},
updateName: () => self,
Expand Down Expand Up @@ -343,7 +340,6 @@ export const currentOtelSpan: Effect.Effect<OtelApi.Span, Cause.NoSuchElementExc
})
)


/** @internal */
export const layerGlobalProvider = Layer.sync(
TracerProvider,
Expand Down
Loading