Skip to content

fix: use npc:GetEntityIndex() and npc:GetTeam() to avoid unexpect behaviors #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2023
Merged

fix: use npc:GetEntityIndex() and npc:GetTeam() to avoid unexpect behaviors #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e242f4
fix: use `npc:GetEntityIndex()` and `npc:GetTeam()` to avoid unexpect…
kdxcxs Mar 27, 2023
5f4f4e7
doc: add changelog to readme
kdxcxs Mar 27, 2023
943d47c
doc: add changelog to readme
kdxcxs Mar 27, 2023
a097369
Merge branch 'master' into sandboxed-getentityid
kdxcxs Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,4 @@ All other information should be explored by reading the source code!
- [2023/3/23 13:30] fix: remove non-hero units after round ends.([#23](https://github.com/Escapingbug/dotaxctf/pull/23), reporter: AAA剑圣)
- [2023/3/24 00:22] feat: support `GetItemInSlot(slot)` to return a sandboxed item.([#24](https://github.com/Escapingbug/dotaxctf/pull/24), reporter: AAA剑圣)
- [2023/3/27 00:22] feat: support getting game time by `GetGameTime()`.([#28](https://github.com/Escapingbug/dotaxctf/pull/28), reporter: Syclover)
- [2023/3/27 23:53] fix: use `npc:GetEntityIndex()` and `npc:GetTeam()` to avoid unexpect behaviors.([#27](https://github.com/Escapingbug/dotaxctf/pull/27), reporter: 114@x1ct34m)
4 changes: 2 additions & 2 deletions sandbox.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function Sandbox:SandboxBaseNPC(npc, readonly)
find_order
)
local units = FindUnitsInRadius(
self:GetTeam(),
npc:GetTeam(),
location,
nil, -- cacheUnit
radius,
Expand Down Expand Up @@ -210,7 +210,7 @@ function Sandbox:SandboxBaseNPC(npc, readonly)
return
end
ExecuteOrderFromTable{
UnitIndex = self:GetEntityIndex(),
UnitIndex = npc:GetEntityIndex(),
OrderType = order_type,
TargetIndex = target_index,
AbilityIndex = ability_index,
Expand Down