Skip to content

Add ConcurrentHashMap.KeySetView serializer #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theigl merged 2 commits into from
May 6, 2025
Merged

Add ConcurrentHashMap.KeySetView serializer #1183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e8938f
Add ConcurrentHashMap.KeySetView serializer
bergander May 5, 2025
96015bd
Add ConcurrentHashMap.KeySetView serializer
bergander May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add ConcurrentHashMap.KeySetView serializer
  • Loading branch information
@bergander
bergander committed May 6, 2025
commit 96015bdf588d6144daa7fed992e96bfcaf3dda8a
10 changes: 5 additions & 5 deletions src/com/esotericsoftware/kryo/serializers/DefaultSerializers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,18 +855,18 @@ private PriorityQueue createPriorityQueue (Class<? extends Collection> type, int

/** Serializer for {@link ConcurrentHashMap.KeySetView}.
* @author Andreas Bergander */
public static class KeySetViewSerializer extends CollectionSerializer<ConcurrentHashMap.KeySetView> {
protected void writeHeader (Kryo kryo, Output output, ConcurrentHashMap.KeySetView set) {
public static class KeySetViewSerializer extends Serializer<ConcurrentHashMap.KeySetView> {
public void write (Kryo kryo, Output output, ConcurrentHashMap.KeySetView set) {
kryo.writeClassAndObject(output, set.getMap());
kryo.writeClassAndObject(output, set.getMappedValue());
}

protected ConcurrentHashMap.KeySetView create (Kryo kryo, Input input, Class<? extends ConcurrentHashMap.KeySetView> type, int size) {
public ConcurrentHashMap.KeySetView read (Kryo kryo, Input input, Class<? extends ConcurrentHashMap.KeySetView> type) {
return createKeySetView((ConcurrentHashMap)kryo.readClassAndObject(input), kryo.readClassAndObject(input));
}

protected ConcurrentHashMap.KeySetView createCopy (Kryo kryo, ConcurrentHashMap.KeySetView original) {
return createKeySetView(original.getMap(), original.getMappedValue());
public ConcurrentHashMap.KeySetView copy (Kryo kryo, ConcurrentHashMap.KeySetView original) {
return createKeySetView(kryo.copy(original.getMap()), kryo.copy(original.getMappedValue()));
}

private ConcurrentHashMap.KeySetView createKeySetView (ConcurrentHashMap map, Object mappedValue) {
Expand Down
6 changes: 3 additions & 3 deletions test/com/esotericsoftware/kryo/serializers/DefaultSerializersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ void testConcurrentHashMapKeySetView () {
set.add(12);
kryo.register(ConcurrentHashMap.KeySetView.class, new KeySetViewSerializer());
kryo.register(ConcurrentHashMap.class);
roundTrip(13, set);
roundTrip(9, set);
}

@Test
Expand All @@ -474,15 +474,15 @@ void testConcurrentHashMapKeySetViewFromExistingMap () {

kryo.register(ConcurrentHashMap.KeySetView.class, new KeySetViewSerializer());
kryo.register(ConcurrentHashMap.class);
roundTrip(22, set);
roundTrip(15, set);
}

@Test
void testEmptyConcurrentHashMapKeySetView () {
ConcurrentHashMap.KeySetView set = ConcurrentHashMap.newKeySet();
kryo.register(ConcurrentHashMap.KeySetView.class, new KeySetViewSerializer());
kryo.register(ConcurrentHashMap.class);
roundTrip(6, set);
roundTrip(5, set);
}

@Test
Expand Down