Skip to content

compare v1.4.2 changes with the updated version 4.3.3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arienemaiara wants to merge 16 commits into
base: master
Choose a base branch
from
Open

compare v1.4.2 changes with the updated version 4.3.3 #3

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dffaa85
fix(ios): edge case when non-interactive notification is tapped
mvayngrib Apr 3, 2019
ec2d6d7
fix: mis-emission of notification opened event
mvayngrib Apr 3, 2019
8066938
fix: propagate error when user denies permission
mvayngrib Apr 4, 2019
3edca5f
rename to publish under @exodus in npm
mvayngrib Apr 4, 2019
b29368e
1.3.1
mvayngrib Apr 4, 2019
1e9dfc4
fix: specify requiresMainQueueSetup -> YES, to remove annoying warning
mvayngrib Apr 4, 2019
83ea4c6
1.3.2
mvayngrib Apr 4, 2019
f5a3011
feat: support requesting local-only notifications
mvayngrib Apr 5, 2019
6b53f9d
1.4.0
mvayngrib Apr 5, 2019
c959e8a
fix: default requestPermissions to remote:true
mvayngrib Apr 5, 2019
96fdfba
1.4.1
mvayngrib Apr 5, 2019
1d144e8
fix: use RCTConvert to interpret options
mvayngrib Apr 5, 2019
c35a2e8
1.4.2
mvayngrib Apr 5, 2019
433b0d5
docs: rm broken s3 img from readme
mvayngrib Nov 9, 2021
a6a250c
Update README.md
arienemaiara Feb 13, 2023
6d75206
Update README.md
arienemaiara Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(ios): edge case when non-interactive notification is tapped
  • Loading branch information
@mvayngrib
mvayngrib committed Apr 3, 2019
commit dffaa859655ff43d03376ef600817ddc5cd82c1d
22 changes: 20 additions & 2 deletions RNNotifications/RNNotifications.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,26 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center willPresentNot
- (void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNotificationResponse:(UNNotificationResponse *)response withCompletionHandler:(void (^)(void))completionHandler
{
NSString* identifier = response.actionIdentifier;
NSDictionary* userInfo = response.notification.request.content.userInfo;
if ([identifier isEqualToString:UNNotificationDefaultActionIdentifier]) {
if ([RNNotificationsBridgeQueue sharedInstance].jsIsReady) {
dispatch_async(dispatch_get_main_queue(), ^{
[self checkAndSendEvent:RNNotificationOpened body:userInfo];
});
} else {
[[RNNotificationsBridgeQueue sharedInstance] postNotification:userInfo];
}

completionHandler();
return;
}

// TODO: emit this
// if ([identifier isEqualToString:UNNotificationDismissActionIdentifier]) {
// [self checkAndSendEvent:RNNotificationDismissed body:userInfo];
// return;
// }

NSString* completionKey = [NSString stringWithFormat:@"%@.%@", identifier, [NSString stringWithFormat:@"%ld", (long)[[NSDate date] timeIntervalSince1970]]];
NSMutableDictionary* info = [[NSMutableDictionary alloc] initWithDictionary:@{ @"identifier": identifier, @"completionKey": completionKey }];

Expand All @@ -250,8 +270,6 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNoti
info[@"text"] = text;
}

NSDictionary* userInfo = response.notification.request.content.userInfo;

// add notification custom data
if (userInfo != NULL) {
info[@"notification"] = userInfo;
Expand Down