chore: Replace Bluebird promises with native promises (cypress-io#33056)

* replace bluebird with native Promise

* replace bluebird in fixture file

* replace bluebird in spawn file

* replace bluebird and use fsExtra

* replace pathExistsAsync with native method

* use async await instead of Promise.try

* fix formStatePath

* fix Promise.try

* fix for formStatePath

* fix lint

* Update packages/config/src/project/utils.ts

* remove unused Bluebird import

* fix indentation

---------

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

cli/lib/exec/spawn.ts

@@ -2,7 +2,6 @@ import _ from 'lodash'
 import os from 'os'
 import cp from 'child_process'
 import path from 'path'
-import Bluebird from 'bluebird'
 import Debug from 'debug'
 import util from '../util'
 import state from '../tasks/state'
@@ -58,7 +57,7 @@ function createSpawnFunction (
   options: any,
 ) {
   return (overrides: any = {}): any => {
-    return new Bluebird((resolve: any, reject: any) => {
+    return new Promise((resolve: any, reject: any) => {
       _.defaults(overrides, {
         onStderrData: false,
       })

packages/server/lib/cypress.ts

@@ -7,7 +7,6 @@
 // essentially do it all again when we boot the correct
 // mode.
 
-import Promise from 'bluebird'
 import Debug from 'debug'
 import { getPublicConfigKeys } from '@packages/config'
 import argsUtils from './util/args'
@@ -102,7 +101,7 @@ export = {
     // wrap all of this in a promise to force the
     // promise interface - even if it doesn't matter
     // in dev mode due to cp.spawn
-    return Promise.try(() => {
+    return Promise.resolve().then(() => {
       // if we have the electron property on versions
       // that means we're already running in electron
       // like in production and we shouldn't spawn a new
@@ -284,7 +283,7 @@ export = {
           return exit(results.totalFailed ?? 0)
         }
         default: {
-            throw new Error(`Cannot start. Invalid mode: '${mode}'`)
+          throw new Error(`Cannot start. Invalid mode: '${mode}'`)
         }
       }
     } catch (err) {

packages/server/lib/fixture.ts

@@ -2,7 +2,6 @@ import path from 'path'
 import check from 'syntax-error'
 import debugModule from 'debug'
 import coffee from 'coffeescript'
-import Bluebird from 'bluebird'
 import jsonParseBetterErrors from 'json-parse-even-better-errors'
 import stripAnsi from 'strip-ansi'
 import * as errors from './errors'
@@ -98,7 +97,7 @@ export async function fileExists (p: string) {
 
 export async function parseFile (p: string, fixture: string, options: { encoding?: (ObjectEncodingOptions & { flag?: string | undefined }) | BufferEncoding | null } = {}) {
   if (queue[p]) {
-    await Bluebird.delay(1)
+    await new Promise<void>((resolve) => setTimeout(resolve, 1))
 
     return parseFile(p, fixture, options)
   }

packages/server/lib/saved_state.ts

@@ -1,11 +1,10 @@
 import _ from 'lodash'
 import path from 'path'
 import Debug from 'debug'
-import Bluebird from 'bluebird'
 import appData from './util/app_data'
 import { getCwd } from './cwd'
 import { File as FileUtil } from './util/file'
-import { fs } from './util/fs'
+import fsExtra from 'fs-extra'
 import { AllowedState, allowedKeys } from '@packages/types'
 import { globalPubSub } from '@packages/data-context'
 import { logError } from '@packages/stderr-filtering'
@@ -14,54 +13,40 @@ const debug = Debug('cypress:server:saved_state')
 
 const stateFiles: Record<string, typeof FileUtil> = {}
 
-export const formStatePath = (projectRoot?: string) => {
-  return Bluebird.try(() => {
-    debug('making saved state from %s', getCwd())
+export const formStatePath = async (projectRoot?: string) => {
+  debug('making saved state from %s', getCwd())
 
-    if (projectRoot) {
-      debug('for project path %s', projectRoot)
+  if (projectRoot) {
+    debug('for project path %s', projectRoot)
 
-      return projectRoot
-    }
+    return path.join(appData.toHashName(projectRoot), 'state.json')
+  }
 
-    debug('missing project path, looking for project here')
+  debug('missing project path, looking for project here')
 
-    let cypressConfigPath = getCwd('cypress.config.js')
+  const cwd = getCwd()
 
-    return fs.pathExistsAsync(cypressConfigPath)
-    .then((found) => {
-      if (found) {
-        debug('found cypress file %s', cypressConfigPath)
-        projectRoot = getCwd()
+  const jsConfig = getCwd('cypress.config.js')
 
-        return
-      }
+  if (await fsExtra.pathExists(jsConfig)) {
+    debug('found cypress file %s', jsConfig)
+    const root = cwd
 
-      cypressConfigPath = getCwd('cypress.config.ts')
+    return path.join(appData.toHashName(root), 'state.json')
+  }
 
-      return fs.pathExistsAsync(cypressConfigPath)
-    })
-    .then((found) => {
-      if (found) {
-        debug('found cypress file %s', cypressConfigPath)
-        projectRoot = getCwd()
-      }
+  const tsConfig = getCwd('cypress.config.ts')
 
-      return projectRoot
-    })
-  }).then((projectRoot) => {
-    const fileName = 'state.json'
+  if (await fsExtra.pathExists(tsConfig)) {
+    debug('found cypress file %s', tsConfig)
+    const root = cwd
 
-    if (projectRoot) {
-      debug(`state path for project ${projectRoot}`)
-
-      return path.join(appData.toHashName(projectRoot), fileName)
-    }
+    return path.join(appData.toHashName(root), 'state.json')
+  }
 
-    debug('state path for global mode')
+  debug('state path for global mode')
 
-    return path.join('__global__', fileName)
-  })
+  return path.join('__global__', 'state.json')
 }
 
 const normalizeAndAllowSet = (set, key, value) => {
@@ -89,8 +74,8 @@ const normalizeAndAllowSet = (set, key, value) => {
 }
 
 interface SavedStateAPI {
-  get: () => Bluebird<AllowedState>
-  set: (stateToSet: AllowedState) => Bluebird<void>
+  get: () => Promise<AllowedState>
+  set: (stateToSet: AllowedState) => Promise<void>
 }
 
 export const create = (projectRoot?: string, isTextTerminal: boolean = false): Promise<SavedStateAPI> => {

packages/server/test/unit/modes/interactive_spec.js

@@ -122,15 +122,15 @@ describe('gui/interactive', () => {
   })
 
   context('.ready', () => {
-    beforeEach(function () {
+    beforeEach(async function () {
       this.win = {}
       this.state = {}
 
       sinon.stub(menu, 'set')
       sinon.stub(Windows, 'open').resolves(this.win)
       sinon.stub(Windows, 'trackState')
 
-      const state = savedState.create()
+      const state = await savedState.create()
 
       sinon.stub(state, 'get').resolves(this.state)
     })