Skip to content

Add in data for FRB 181112 and FRB 190523#37

Merged
profxj merged 20 commits into
masterfrom
next_one
Sep 10, 2019
Merged

Add in data for FRB 181112 and FRB 190523#37
profxj merged 20 commits into
masterfrom
next_one

Conversation

@profxj
Copy link
Copy Markdown
Contributor

@profxj profxj commented Sep 8, 2019

As titled. Here are the specific CHANGES:

  • Add in FRB 181112 and FRB 190523 data
  • Add access to galaxy spectra
  • Add random_assoc script

These are largely in support of the Prochaska+2019 paper.

No new tests.

@profxj profxj requested review from SunilSimha and ntejos September 8, 2019 23:29
Copy link
Copy Markdown
Collaborator

@SunilSimha SunilSimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested minor changes. The rest seems fine.

Comment thread frb/builds/build_fg.py Outdated
Comment thread frb/builds/build_fg.py
Comment thread frb/scripts/build.py Outdated
@profxj
Copy link
Copy Markdown
Contributor Author

profxj commented Sep 10, 2019

Merging

@profxj profxj merged commit f70fba7 into master Sep 10, 2019
@profxj profxj deleted the next_one branch September 10, 2019 09:17
tarraneh pushed a commit that referenced this pull request Nov 23, 2020
Add in data for FRB 181112 and FRB 190523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants