This repository was archived by the owner on Sep 22, 2024. It is now read-only.
fixpkg: nodejs-electron11-bin #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launcher has used the wrong version of electron, fix it now
Member
|
I think it would be better to also add a changelog and bump the release whenever fixing something... |
sztsian
reviewed
Mar 16, 2022
| @@ -0,0 +1,21 @@ | |||
| Copyright (c) Electron contributors | |||
Member
There was a problem hiding this comment.
I think upstream already have this file in the source, so no need to copy again?
Member
There was a problem hiding this comment.
Besides, license can be listed in the %file section.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launcher has used the wrong version of electron, fix it now