Skip to content

Conversation

@Kallinteris-Andreas
Copy link
Collaborator

Description

Fixes #821

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas mentioned this pull request Dec 9, 2023
35 tasks
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review December 9, 2023 14:38
@Kallinteris-Andreas Kallinteris-Andreas changed the title Fix Reacher-v5 & Pusher-v5 reward function being the previous state Fix Reacher-v5 & Pusher-v5 reward function being calculated using previous state Dec 9, 2023
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the training curves within the related issue, lgtm

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 9dc17dc into Farama-Foundation:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] [MuJoCo] Reacher And Pusher reward is calculated prior to transition

2 participants