Skip to content

Conversation

@fbartho
Copy link
Contributor

@fbartho fbartho commented May 29, 2018

I noticed some trivial typos in the index.d.ts.

  1. Some of the typos have no effect as they're a typo in the name of a parameter eg. inextMessage
  2. Some of the typos are actually a mismatch in the real name of the props eg. containertoPreviousStyle vs containerToPreviousStyle -- looking at the JS code, the correct name is containerToPreviousStyle

@fbartho
Copy link
Contributor Author

fbartho commented May 29, 2018

Note: I'm happy to become a contributor/maintainer to this repo, as I'm looking at integrating this for my company's purposes, and I notice several other PRs that have changes my team would benefit from.

/cc @xcarpentier

@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files          20       20           
  Lines         498      498           
  Branches      104      104           
=======================================
  Hits          215      215           
  Misses        216      216           
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbf812...c843157. Read the comment docs.

Copy link

@lucasbento lucasbento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@xcarpentier xcarpentier merged commit 7f98b26 into FaridSafi:master Jun 5, 2018
chilinh added a commit to chilinh/react-native-gifted-chat that referenced this pull request Jun 18, 2018
* r_master:
  Move listViewProps to the end (FaridSafi#882)
  chore(package): update react-test-renderer to version 16.4.0 (FaridSafi#868)
  chore(package): update babel-jest to version 23.0.0 (FaridSafi#869)
  Update and Fix Slack Example (FaridSafi#895)
  Remove prop removeClippedSubviews on Flatlist (FaridSafi#897)
  Update Chatkit readme.md
  Fix typos in TS Types (FaridSafi#877)
  Modified for flatlist (from FaridSafi#629) (FaridSafi#705)
  fix tabs
  ignore example folder
  Add Chatkit asset to README.md
  Add Chatkit banner asset
  chore(package): update react-test-renderer to version 16.3.2 (FaridSafi#829)
  Update README.md (FaridSafi#827)
  add image beacon to readme
  chore(package): update react-test-renderer to version 16.3.1 (FaridSafi#821)

# Conflicts:
#	.eslintignore
#	src/MessageContainer.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants